fixed css escape chars #4104
fixed css escape chars #4104
Conversation
Build Size ReportChanges to minified artifacts in 5 files changedTotal change +68 B View Changes
|
Build Size ReportChanges to minified artifacts in 5 files changedTotal change +56 B View Changes
|
Build Size ReportChanges to minified artifacts in 5 files changedTotal change +67 B View Changes
|
|
@joshgoebel any input ? |
src/languages/css.js
Outdated
| @@ -14,7 +14,7 @@ export default function(hljs) { | |||
| const VENDOR_PREFIX = { begin: /-(webkit|moz|ms|o)-(?=[a-z])/ }; | |||
| const AT_MODIFIERS = "and or not only"; | |||
| const AT_PROPERTY_RE = /@-?\w[\w]*(-\w+)*/; // @-webkit-keyframes | |||
| const IDENT_RE = '[a-zA-Z-][a-zA-Z0-9_-]*'; | |||
| const IDENT_RE = '[a-zA-Z-][a-zA-Z0-9_-]*(\\\\:[a-zA-Z0-9_-]+)*'; | |||
There was a problem hiding this comment.
Is :: escaping supported? Or escaping any other chars? Feels like this is just handling this one edge case vs the concept of escaping in general - are there other uses?
There was a problem hiding this comment.
ive managed to generalize to include other special chars in the new commit pls review
Build Size ReportChanges to minified artifacts in 5 files changedTotal change +130 B View Changes
|
Build Size ReportChanges to minified artifacts in 3 files changedTotal change +113 B View Changes
|
Build Size ReportChanges to minified artifacts in 2 files changedTotal change +112 B View Changes
|
Build Size ReportChanges to minified artifacts in 5 files changedTotal change +75 B View Changes
|
| @@ -13,8 +13,9 @@ export default function(hljs) { | |||
| const modes = css.MODES(hljs); | |||
| const VENDOR_PREFIX = { begin: /-(webkit|moz|ms|o)-(?=[a-z])/ }; | |||
| const AT_MODIFIERS = "and or not only"; | |||
| const AT_PROPERTY_RE = /@-?\w[\w]*(-\w+)*/; // @-webkit-keyframes | |||
| const IDENT_RE = '[a-zA-Z-][a-zA-Z0-9_-]*'; | |||
| const AT_PROPERTY_RE = /@-?\b\w[\w-]*\b/; // @-webkit-keyframes | |||
There was a problem hiding this comment.
What are the changes here trying to do?
|
Sorry for the delay. While coming back to this I just remembered that we support many CSS-like grammars - and many of those allow plain old CSS as well as their other syntactic improvements. SO... to accept a
There is a script to help with this.
After that you need to work with the less, stylus, and scss grammars to get the markup tests passing - ie their on CSS output must exactly match the output of the CSS grammar. |
|
Also perhaps look at the |
Resolves #3965
(fixed the branch issue)
before
after
Checklist
CHANGES.md