even game complexity should be reduced

Signed-off-by: hikarikumo <[email protected]>

README.md

@@ -2,8 +2,8 @@ requires python >= 3.7
 
 # CodeClimate Maintainability
 [![Maintainability](https://api.codeclimate.com/v1/badges/d8d8ba9440c8786c2ccf/maintainability)](https://codeclimate.com/github/hikarikumo/python-project-lvl1/maintainability)
-# CodeClimate test coverage
-[![Test Coverage](https://api.codeclimate.com/v1/badges/d8d8ba9440c8786c2ccf/test_coverage)](https://codeclimate.com/github/hikarikumo/python-project-lvl1/test_coverage)
+<!-- # CodeClimate test coverage
+[![Test Coverage](https://api.codeclimate.com/v1/badges/d8d8ba9440c8786c2ccf/test_coverage)](https://codeclimate.com/github/hikarikumo/python-project-lvl1/test_coverage) -->
 # travis ci
 [![Build Status](https://travis-ci.com/hikarikumo/python-project-lvl1.svg?branch=master)](https://travis-ci.com/hikarikumo/python-project-lvl1)
 # asciinema: brain-games brain-even

brain_games/calc_game.py

@@ -1,6 +1,6 @@
+from cli import greet_first, welcome_user
 import random
 import prompt
-from cli import greet_first, welcome_user
 
 
 OPERATIONS = {
@@ -25,7 +25,7 @@ def check_answer(question, answer, correct_answer):
         print(f'Your answer: {answer}')
         print('Correct!')
         return True
-    print(f"'{answer}' is wrong answer ;(. Correct answer was '{correct_answer}'")
+    print(f"'{answer}' is a wrong answer ;(. Correct answer was '{correct_answer}'")
     return False
 
 

brain_games/cli.py

@@ -28,4 +28,4 @@ def main():
 
 
 if __name__ == '__main__':
-    main()
+    main()

brain_games/even_game.py

@@ -1,19 +1,17 @@
-# -*- coding:utf-8 -*-
-
-"""Function declaration to verify the answers."""
-
 import prompt
 import random
 import general_module
 from cli import greet_first, welcome_user
 
-
 def check_if_even(number):
     """Return true if even."""
-    if number % 2 == 0:
-        return True
-    return False
+    return number % 2 == 0
+
+def even_question():
+    print("Answer 'yes' if number even otherwise answer 'no'.")
 
+def even_wrong_answer(correct_answer):
+    print(f"'{correct_answer}' is wrong answer ;(. Correct answer was '{'no' if correct_answer == 'yes' else 'yes'}.")
 
 def even_game():
     """
@@ -29,41 +27,31 @@ def even_game():
     random_number = random.randint(0, 1000)
     even_result = check_if_even(random_number)
     print(random_number)
-    general_module.even_question()
-    answer = prompt.string()
-    while answer == 'yes':
-        if even_result:
+    even_question()
+    answer = prompt.string().lower()  # Convert answer to lowercase for case-insensitive comparison
+    if answer in ['yes', 'no']:
+        if (answer == 'yes' and even_result) or (answer == 'no' and not even_result):
             return True
-        general_module.even_wrong_answer_yes(answer)
+        even_wrong_answer(answer)
         return False
-    while answer == 'no':
-        if not even_result:
-            return True
-        general_module.even_wrong_answer_no(answer)
+    else:
+        print("Invalid input. Please answer 'yes' or 'no'.")
         return False
 
-
 def even_game_logic(name):
     """Even game main logic."""
-    counter = 1
-    while counter <= 3:
+    for _ in range(3):
         received_value = even_game()
-        if received_value:
-            general_module.correct_answer()
-            if counter == 3:
-                general_module.game_success_finish(name)
-        else:
+        if not received_value:
             general_module.try_again(name)
             break
-        counter += 1
-
+        general_module.correct_answer()
 
 def main():
     """Run brain-even game."""
     greet_first()
     name = welcome_user()
     even_game_logic(name)
 
-
 if __name__ == '__main__':
-    main()
+    main()

brain_games/general_module.py

@@ -1,9 +1,3 @@
-# -*- coding:utf-8 -*-
-
-"""General games module."""
-
-
-
 def correct_answer():
     print('Correct!')
 
@@ -15,14 +9,3 @@ def game_success_finish(name):
 def try_again(name):
     print("Let's try again, ", name, "!", sep='')
 
-
-def even_question():
-    print("Answer 'yes' if number even otherwise answer 'no'.")
-
-
-def even_wrong_answer_yes(answer):
-    print("'" + answer + "'" + " is wrong answer ;(. Correct answer was 'no'.")
-
-
-def even_wrong_answer_no(answer):
-    print("'" + answer + "'" + " is wrong answer ;(. Correct answer was 'yes'.")

brain_games/scripts/brain_calc.py

@@ -1,5 +1,3 @@
-# -*- coding:utf-8 -*-
-
 """Main script for calc game."""