feat: add slot_index property to signers #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Vercel deployment URL: https://signer-metrics-o8d4jit2k-hirosystems.vercel.app 🚀 |
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
blockstack-devops
pushed a commit
that referenced
this pull request
Nov 8, 2024
## [0.8.0](v0.7.0...v0.8.0) (2024-11-08) ### Features * add slot_index property to signers ([#46](#46)) ([79e399a](79e399a))
|
🎉 This PR is included in version 0.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
janniks
reviewed
Nov 8, 2024
| pgm.dropIndex('reward_set_signers', ['block_height']); | ||
| pgm.dropIndex('reward_set_signers', ['cycle_number']); | ||
| pgm.dropConstraint('reward_set_signers', 'reward_set_signers_cycle_unique'); | ||
| pgm.renameTable('reward_set_signers', 'reward_set_signers_old-no-slot-index'); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #40
The sql migration just drops the current table to trigger the existing runtime logic which will detect missing cycle signer sets, fetch them, and insert them (this time with the slot_index data). This is cleaner and less error-prone than an alter-table migration + missing slot_index detection + table updating logic.