Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/add-initial-regtest-prototype #19

Draft
wants to merge 18 commits into
base: develop
Choose a base branch
from
Draft

feat/add-initial-regtest-prototype #19

wants to merge 18 commits into from

Conversation

janniks
Copy link
Collaborator

@janniks janniks commented Mar 18, 2024 •
edited
Loading

wip 🚧

Functional tests to generate TSVs for testing in the API

  • stack (in reward phase)
  • stack (right before reward phase)
  • stack (in prepare phase)
  • stack (in reward phase) and extend (in reward phase)
  • stack (in reward phase) and extend (in prepare phase)
  • stack (in reward phase) and increase (in reward phase)
  • stack (in reward phase) and increase (in prepare phase)
  • pool: A and B delegate, P stacks for both (in reward phase)
  • pool: A and B delegate, P stacks for A (in reward phase), P stacks for B (in prepare phase)
  • more coming

hugocaillard
hugocaillard requested changes May 6, 2024
View reviewed changes
Copy link

@hugocaillard hugocaillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it doesn't handle numbers > MAX_SAFE_INTEGER?
Could you add a test case for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugocaillard hugocaillard hugocaillard requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janniks @hugocaillard