Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update amazon bucket values to invalid names #1574

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

janniks
Copy link
Collaborator

@janniks janniks commented Oct 19, 2023

This PR was published to npm with the version 6.9.1-pr.b56d58a.0
e.g. npm install @stacks/[email protected] --save-exact

Buckets weren't used for anything. The data wasn't read, but for examples it might be easier to show an "example" value, so people aren't confused by this in the future.


Bucket names can consist only of lowercase letters, numbers, dots (.), and hyphens (-). Bucket names must begin and end with a letter or number.

_example_ should be invalid, so these can't be activated. This way we don't need to maintain any buckets.

@vercel
Copy link

vercel bot commented Oct 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stacksjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2023 3:13pm

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #1574 (b56d58a) into main (ca0513c) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##             main    #1574    +/-   ##
========================================
  Coverage   66.32%   66.32%            
========================================
  Files         119      119            
  Lines        8686     8686            
  Branches     1909     1936    +27     
========================================
  Hits         5761     5761            
+ Misses       2798     2688   -110     
- Partials      127      237   +110     
Files Coverage Δ
packages/auth/tests/sampleData.ts 100.00% <100.00%> (ø)
packages/profile/tests/sampleData.ts 100.00% <100.00%> (ø)

... and 24 files with indirect coverage changes

@janniks janniks requested a review from aravindgee October 19, 2023 15:23
@janniks janniks self-assigned this Oct 19, 2023
@janniks janniks merged commit 3ba16d8 into main Oct 26, 2023
@janniks janniks deleted the fix/update-bucket-names branch October 26, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants