Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Reduce wrapping of types for public key appending #1734

Merged
merged 1 commit into from
Sep 24, 2024
Merged

feat: Reduce wrapping of types for public key appending #1734

merged 1 commit into from
Sep 24, 2024

Conversation

janniks
Copy link
Collaborator

@janniks janniks commented Jul 31, 2024 •
edited by github-actions bot
Loading

This PR was published to npm with the version 6.14.1-pr.59+761f0c92
e.g. npm install @stacks/[email protected]+761f0c92 --save-exact

  • Reducing "wrapper" types, so developers can use raw types instead

@vercel Vercel
Copy link

vercel bot commented Jul 31, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stacksjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2024 1:20pm

@janniks janniks force-pushed the 07-31-feat_reduce_wrapping_of_types_for_public_key_appending branch from 4244167 to a902046 Compare July 31, 2024 21:06
@janniks janniks force-pushed the 07-31-fix_move_more_helper_functions_to_take_network_parameter branch from 66c2963 to f1453c6 Compare July 31, 2024 21:06
@codecov Codecov
Copy link

codecov bot commented Jul 31, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/transactions/src/transaction.ts 83.33% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@janniks janniks requested a review from beguene August 1, 2024 12:56
beguene
beguene approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@beguene beguene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, I missed this one.
LGTM !

@janniks janniks force-pushed the 07-31-fix_move_more_helper_functions_to_take_network_parameter branch from f1453c6 to 2fc0e3b Compare September 17, 2024 14:15
@janniks janniks force-pushed the 07-31-feat_reduce_wrapping_of_types_for_public_key_appending branch 2 times, most recently from 2051050 to 74f55c7 Compare September 17, 2024 14:35
@janniks janniks force-pushed the 07-31-fix_move_more_helper_functions_to_take_network_parameter branch from 2fc0e3b to 8bb7a38 Compare September 17, 2024 14:35
@janniks janniks force-pushed the 07-31-fix_move_more_helper_functions_to_take_network_parameter branch from 8bb7a38 to 289a015 Compare September 17, 2024 14:46
@janniks janniks force-pushed the 07-31-feat_reduce_wrapping_of_types_for_public_key_appending branch from 74f55c7 to 3d54304 Compare September 17, 2024 14:46
@janniks janniks force-pushed the 07-31-fix_move_more_helper_functions_to_take_network_parameter branch from 289a015 to 7f780fc Compare September 17, 2024 14:50
@janniks janniks force-pushed the 07-31-feat_reduce_wrapping_of_types_for_public_key_appending branch 3 times, most recently from 974b3a7 to fd42056 Compare September 17, 2024 14:57
@janniks janniks force-pushed the 07-31-fix_move_more_helper_functions_to_take_network_parameter branch from 0bbc30e to abf42c1 Compare September 17, 2024 14:57
@janniks janniks force-pushed the 07-31-feat_reduce_wrapping_of_types_for_public_key_appending branch from fd42056 to 3b333bc Compare September 17, 2024 14:59
@janniks janniks force-pushed the 07-31-fix_move_more_helper_functions_to_take_network_parameter branch from abf42c1 to 0128e87 Compare September 17, 2024 14:59
@janniks janniks force-pushed the 07-31-feat_reduce_wrapping_of_types_for_public_key_appending branch from 3b333bc to 07f554e Compare September 17, 2024 15:00
@janniks janniks force-pushed the 07-31-fix_move_more_helper_functions_to_take_network_parameter branch 2 times, most recently from 05b0dc6 to d0a77fd Compare September 17, 2024 15:00
@janniks janniks force-pushed the 07-31-feat_reduce_wrapping_of_types_for_public_key_appending branch 2 times, most recently from 82801e2 to f4602a7 Compare September 17, 2024 15:02
@janniks janniks force-pushed the 07-31-fix_move_more_helper_functions_to_take_network_parameter branch from 315d97e to c8e6a27 Compare September 17, 2024 15:04
@janniks janniks force-pushed the 07-31-feat_reduce_wrapping_of_types_for_public_key_appending branch 2 times, most recently from 994f42c to 85b9b70 Compare September 17, 2024 15:05
@janniks janniks force-pushed the 07-31-feat_reduce_wrapping_of_types_for_public_key_appending branch from 85b9b70 to c038a53 Compare September 17, 2024 15:06
@janniks janniks force-pushed the 07-31-fix_move_more_helper_functions_to_take_network_parameter branch from 519b9c7 to d542e0e Compare September 17, 2024 15:06
@janniks janniks force-pushed the 07-31-feat_reduce_wrapping_of_types_for_public_key_appending branch from c038a53 to f134dfc Compare September 17, 2024 15:06
@janniks janniks force-pushed the 07-31-fix_move_more_helper_functions_to_take_network_parameter branch from d542e0e to ec7f074 Compare September 17, 2024 15:06
@janniks janniks force-pushed the 07-31-feat_reduce_wrapping_of_types_for_public_key_appending branch from f134dfc to b1f4558 Compare September 17, 2024 15:07
@janniks janniks force-pushed the 07-31-fix_move_more_helper_functions_to_take_network_parameter branch from ec7f074 to 4b36157 Compare September 17, 2024 15:07
@janniks janniks force-pushed the 07-31-feat_reduce_wrapping_of_types_for_public_key_appending branch from b1f4558 to 723b257 Compare September 17, 2024 15:08
@janniks janniks force-pushed the 07-31-fix_move_more_helper_functions_to_take_network_parameter branch 2 times, most recently from a1fb62a to 670de43 Compare September 17, 2024 15:11
@janniks janniks force-pushed the 07-31-feat_reduce_wrapping_of_types_for_public_key_appending branch 2 times, most recently from 19808cb to 9bc4af4 Compare September 17, 2024 15:12
@janniks janniks force-pushed the 07-31-fix_move_more_helper_functions_to_take_network_parameter branch 2 times, most recently from 3e43f79 to 76575a3 Compare September 17, 2024 15:13
@janniks janniks force-pushed the 07-31-feat_reduce_wrapping_of_types_for_public_key_appending branch from 9bc4af4 to 761f0c9 Compare September 17, 2024 15:13
@janniks janniks force-pushed the 07-31-fix_move_more_helper_functions_to_take_network_parameter branch from 76575a3 to 413f206 Compare September 24, 2024 13:12
@janniks janniks force-pushed the 07-31-feat_reduce_wrapping_of_types_for_public_key_appending branch from 761f0c9 to 2c9bd6d Compare September 24, 2024 13:12
Base automatically changed from 07-31-fix_move_more_helper_functions_to_take_network_parameter to next September 24, 2024 13:13
@janniks janniks force-pushed the 07-31-feat_reduce_wrapping_of_types_for_public_key_appending branch from 2c9bd6d to 57443aa Compare September 24, 2024 13:13
@janniks janniks merged commit c439e6f into next Sep 24, 2024
7 of 8 checks passed
@janniks janniks deleted the 07-31-feat_reduce_wrapping_of_types_for_public_key_appending branch September 24, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beguene beguene beguene approved these changes

Assignees
No one assigned
Labels
None yet
Projects
DevTools
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janniks @beguene