refactor: Minor refactoring to match common theme #1749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
janniks
commented
Oct 22, 2024
•
janniks
commented
- refactor some uint8array methods to match the general theme
- remove unneeded overloads
- add @ignore and deprecation comments
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
janniks
force-pushed
the
10-22-refactor_minor_refactoring_to_match_common_theme
branch
from
6f0e16c
to
e78cc74
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
hugocaillard
requested changes
Oct 23, 2024
janniks
force-pushed
the
10-22-refactor_minor_refactoring_to_match_common_theme
branch
from
991a12b
to
620a507
Compare
janniks
force-pushed
the
10-22-refactor_minor_refactoring_to_match_common_theme
branch
from
620a507
to
f8dba25
Compare
janniks
force-pushed
the
10-22-refactor_minor_refactoring_to_match_common_theme
branch
from
f8dba25
to
e6f2832
Compare
janniks
force-pushed
the
10-21-fix_switch_to_a_network_and_client_param_solution
branch
from
8cf2e30
to
d753ab2
Compare
janniks
force-pushed
the
10-22-refactor_minor_refactoring_to_match_common_theme
branch
from
e6f2832
to
0676a06
Compare
Base automatically changed from
10-21-fix_switch_to_a_network_and_client_param_solution
to
next
October 25, 2024 18:55
janniks
force-pushed
the
10-22-refactor_minor_refactoring_to_match_common_theme
branch
from
0676a06
to
fa9be48
Compare
janniks
deleted the
10-22-refactor_minor_refactoring_to_match_common_theme
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.