-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17559] Script commands #370
Merged
cosmolev
merged 9 commits into
epic/17128-data-hub-scripting
from
feature/17559-script-commands
Nov 30, 2023
Merged
[17559] Script commands #370
cosmolev
merged 9 commits into
epic/17128-data-hub-scripting
from
feature/17559-script-commands
Nov 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
busybeetree
reviewed
Nov 20, 2023
src/main/java/com/hivemq/cli/commands/hivemq/script/ScriptCreateCommand.java
Outdated
Show resolved
Hide resolved
src/test/java/com/hivemq/cli/commands/hivemq/script/ScriptCreateCommandTest.java
Show resolved
Hide resolved
src/main/java/com/hivemq/cli/commands/hivemq/script/ScriptGetCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/com/hivemq/cli/hivemq/scripts/CreateScriptTask.java
Outdated
Show resolved
Hide resolved
src/test/java/com/hivemq/cli/hivemq/scripts/CreateScriptTaskTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/hivemq/cli/hivemq/scripts/CreateScriptTaskTest.java
Outdated
Show resolved
Hide resolved
…added to commands.
busybeetree
approved these changes
Nov 21, 2023
LukasBrand
reviewed
Nov 22, 2023
LukasBrand
reviewed
Nov 22, 2023
src/main/java/com/hivemq/cli/commands/hivemq/script/ScriptCreateCommand.java
Outdated
Show resolved
Hide resolved
LukasBrand
reviewed
Nov 22, 2023
src/main/java/com/hivemq/cli/converters/ScriptTypeConverter.java
Outdated
Show resolved
Hide resolved
LukasBrand
reviewed
Nov 22, 2023
src/main/java/com/hivemq/cli/hivemq/scripts/CreateScriptTask.java
Outdated
Show resolved
Hide resolved
LukasBrand
reviewed
Nov 22, 2023
src/test/java/com/hivemq/cli/commands/hivemq/script/ScriptCreateCommandTest.java
Outdated
Show resolved
Hide resolved
LukasBrand
reviewed
Nov 22, 2023
src/test/java/com/hivemq/cli/hivemq/scripts/CreateScriptTaskTest.java
Outdated
Show resolved
Hide resolved
We eventually need to add SystemTests to the HiveMQ command subpart but I am ok with system tests for this addition not being part of the PR. |
LukasBrand
reviewed
Nov 23, 2023
...test/java/com/hivemq/cli/commands/hivemq/behaviorpolicy/BehaviorPolicyCreateCommandTest.java
Outdated
Show resolved
Hide resolved
LukasBrand
reviewed
Nov 23, 2023
src/test/java/com/hivemq/cli/commands/hivemq/behaviorstate/BehaviorStateGetCommandTest.java
Outdated
Show resolved
Hide resolved
LukasBrand
reviewed
Nov 23, 2023
src/test/java/com/hivemq/cli/commands/hivemq/datapolicy/DataPolicyCreateCommandTest.java
Outdated
Show resolved
Hide resolved
LukasBrand
reviewed
Nov 23, 2023
src/test/java/com/hivemq/cli/commands/hivemq/script/ScriptDeleteCommandTest.java
Outdated
Show resolved
Hide resolved
LukasBrand
approved these changes
Nov 23, 2023
…haviorPolicyCreateCommandTest.java Co-authored-by: Lukas Brand <[email protected]>
…teCommandTest.java Co-authored-by: Lukas Brand <[email protected]>
…licyCreateCommandTest.java Co-authored-by: Lukas Brand <[email protected]>
…aviorStateGetCommandTest.java Co-authored-by: Lukas Brand <[email protected]>
cosmolev
changed the base branch from
master
to
epic/17128-data-hub-scripting
November 30, 2023 11:16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hivemq.kanbanize.com/ctrl_board/4/cards/17559/details/