minor clean up

hjacobs · Dec 23, 2019 · ca50cc9 · ca50cc9
1 parent 23c449a
commit ca50cc9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/Dockerfile b/Dockerfile
@@ -1,5 +1,4 @@
 FROM python:3.8-slim
-MAINTAINER Henning Jacobs <[email protected]>
 
 WORKDIR /
 
@@ -15,10 +14,14 @@ FROM python:3.8-slim
 
 WORKDIR /
 
+# copy pre-built packages to this image
 COPY --from=0 /usr/local/lib/python3.8/site-packages /usr/local/lib/python3.8/site-packages
+
+# now copy the actual code we will execute (poetry install above was just for dependencies)
 COPY kube_downscaler /kube_downscaler
 
 ARG VERSION=dev
+
 RUN sed -i "s/__version__ = .*/__version__ = '${VERSION}'/" /kube_downscaler/__init__.py
 
 ENTRYPOINT ["python3", "-m", "kube_downscaler"]
diff --git a/Makefile b/Makefile
@@ -6,7 +6,7 @@ TAG              ?= $(VERSION)
 
 default: docker
 
-.PHONY:
+.PHONY: install
 install:
 	poetry install