Skip to content
This repository has been archived by the owner on Oct 3, 2020. It is now read-only.

Add namespace warnings to README and rbac.yaml #57

Merged
merged 1 commit into from
Feb 16, 2020

Conversation

sryabkov
Copy link
Contributor

what

Add namespace warnings toREADME.rst and deploy/common/rbac.yaml

why

  • The current deployment manifests assume that kube-janitor is deployed to the default Kubernetes namespace. If kube-janitor is deployed to a different namespace, this can lead to problems described in 403 Client Error: Forbidden for url #35, at least on GKE.
  • The author solicited this PR over here

notes

  • This is a documentation/comment only PR. It contains no code or configuration changes.

@hjacobs
Copy link
Owner

hjacobs commented Feb 16, 2020

Thanks!

@hjacobs hjacobs merged commit 29c5152 into hjacobs:master Feb 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants