Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Continuous Shape Measures to Geometry Classification #257

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

aarongarrison
Copy link
Contributor

Added in an optional flag to the get_geometry_type_distance method in the mol3D class. This allows for a more straightforward evaluation of the deviation between a structure and an ideal structure.

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 13.95349% with 37 lines in your changes missing coverage. Please review.

Project coverage is 37.41%. Comparing base (d6796e4) to head (5aaac4c).
Report is 2 commits behind head on main.

Files Patch % Lines
molSimplify/Classes/mol3D.py 13.95% 37 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #257      +/-   ##
==========================================
- Coverage   37.49%   37.41%   -0.08%     
==========================================
  Files          89       89              
  Lines       29689    29824     +135     
==========================================
+ Hits        11131    11158      +27     
- Misses      18558    18666     +108     
Flag Coverage Δ
unittests 37.41% <13.95%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jwtoney jwtoney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🫡

@jwtoney jwtoney merged commit 3a22984 into main Aug 5, 2024
10 checks passed
@jwtoney jwtoney deleted the shape_measures branch August 5, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants