Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed a bug that broke lc_names assignment during MOF RACs calculation #277

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

husainadamji
Copy link
Contributor

Previously, lc_names was assigned descriptor_names if j = 0. This assumed that the first linker in the linker list will always be connected to the SBU. This may not be the case all the time. Fixed this by tracking first instance of SBU-connected linker with a boolean.

@husainadamji husainadamji merged commit e2f0a7c into main Oct 28, 2024
8 checks passed
@husainadamji husainadamji deleted the mof branch October 28, 2024 16:43
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.23%. Comparing base (fcc7f20) to head (a636f95).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #277      +/-   ##
==========================================
- Coverage   37.24%   37.23%   -0.01%     
==========================================
  Files          89       89              
  Lines       29990    29992       +2     
==========================================
- Hits        11170    11168       -2     
- Misses      18820    18824       +4     
Flag Coverage Δ
unittests 37.23% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant