Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cylc set stuff #35

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Cylc set stuff #35

merged 3 commits into from
Dec 18, 2023

Conversation

oliver-sanders
Copy link

  • Add the note you suggested about putting the task before the --pre/--out opt for CLI completion.
  • Add cylc set support into cylc tui.

@oliver-sanders oliver-sanders mentioned this pull request Dec 15, 2023
Merged
16 tasks
hjoliver
hjoliver reviewed Dec 18, 2023
View reviewed changes
cylc/flow/scripts/set.py Outdated Show resolved Hide resolved
hjoliver
hjoliver approved these changes Dec 18, 2023
View reviewed changes
Copy link
Owner

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@hjoliver hjoliver merged commit 2f8536a into hjoliver:cylc-set-task Dec 18, 2023
hjoliver added a commit that referenced this pull request Jan 16, 2024
@hjoliver
Squashed commit of the following:
1b0940e 
commit a3da49837f2b60e768784c416c511fe1d1b6d720
Merge: e793ca1 c07392d
Author: Hilary James Oliver <[email protected]>
Date:   Tue Jan 16 15:32:58 2024 +1300

    Merge branch 'master' into cylc-set-task

commit e793ca1
Author: Hilary James Oliver <[email protected]>
Date:   Tue Dec 19 17:49:33 2023 +1300

    working on flow_wait reset ...[skip ci]

commit f6a4f33
Author: Hilary James Oliver <[email protected]>
Date:   Tue Dec 19 15:46:11 2023 +1300

    Handle flow-number skipping.

commit 2f8536a
Merge: 3fddad0 ca8637e
Author: Hilary James Oliver <[email protected]>
Date:   Tue Dec 19 12:12:41 2023 +1300

    Merge pull request #35 from oliver-sanders/cylc-set-stuff

    Cylc set stuff

commit ca8637e
Author: Hilary James Oliver <[email protected]>
Date:   Tue Dec 19 12:12:19 2023 +1300

    Apply suggestions from code review [skip ci]

commit 3fddad0
Author: Hilary James Oliver <[email protected]>
Date:   Sun Dec 17 13:05:48 2023 +1300

    Fix wrong-outputs warning.

commit 7c75fbc
Author: Oliver Sanders <[email protected]>
Date:   Fri Dec 15 10:28:35 2023 +0000

    tui: support the "cylc set" command with default opts

commit cd4a3e3
Author: Oliver Sanders <[email protected]>
Date:   Fri Dec 15 10:18:49 2023 +0000

    set: add note about CLI completion

commit 06fbdea
Author: Hilary James Oliver <[email protected]>
Date:   Fri Dec 15 16:24:39 2023 +1300

    Fix C7 back-compat task removal.

commit ad6e5d7
Merge: 9d320a5 6f62691
Author: Hilary James Oliver <[email protected]>
Date:   Fri Dec 15 15:32:00 2023 +1300

    Merge branch 'master' into cylc-set-task

commit 9d320a5
Author: Hilary James Oliver <[email protected]>
Date:   Fri Dec 15 13:43:05 2023 +1300

    Final functionality tweaks.

commit 8f5c0aa
Author: Hilary James Oliver <[email protected]>
Date:   Thu Dec 14 21:33:08 2023 +1300

    Fix select prev instance from task_states table.

commit 8c34c75
Author: Hilary James Oliver <[email protected]>
Date:   Thu Dec 14 17:50:41 2023 +1300

    Fix functional tests.

commit e65f2c6
Author: Hilary James Oliver <[email protected]>
Date:   Thu Dec 14 16:37:24 2023 +1300

    Logging tweaks.

commit 1148487
Author: Hilary James Oliver <[email protected]>
Date:   Thu Dec 14 16:15:10 2023 +1300

    Fix an integration test.

commit 50a5b49
Author: Hilary James Oliver <[email protected]>
Date:   Thu Dec 14 15:55:34 2023 +1300

    Transient task proxy comment.

commit 4dc5a55
Author: Hilary James Oliver <[email protected]>
Date:   Thu Dec 14 10:40:46 2023 +1300

    Tweak satisfy_me methods.

commit cceb740
Author: Hilary James Oliver <[email protected]>
Date:   Thu Dec 14 10:10:17 2023 +1300

    Remove duplicate block.

commit 6503ac5
Author: Hilary James Oliver <[email protected]>
Date:   Wed Dec 13 16:29:24 2023 +1300

    Demote warning to debug.

commit 70fd970
Author: Hilary James Oliver <[email protected]>
Date:   Tue Dec 12 22:25:10 2023 +1300

    Code review tweaks 2.

commit 1e93707
Author: Hilary James Oliver <[email protected]>
Date:   Tue Dec 12 16:03:40 2023 +1300

    Update cylc/flow/task_pool.py [skip ci]

    Co-authored-by: Oliver Sanders <[email protected]>

commit 9c8b64a
Author: Hilary James Oliver <[email protected]>
Date:   Tue Dec 12 15:29:33 2023 +1300

    Update cylc/flow/task_proxy.py [skip ci]

    Co-authored-by: Oliver Sanders <[email protected]>

commit f592516
Author: Hilary James Oliver <[email protected]>
Date:   Tue Dec 12 13:23:00 2023 +1300

    code review tweaks [skip ci]

commit d2839b4
Author: Hilary James Oliver <[email protected]>
Date:   Fri Dec 8 14:32:48 2023 +1300

    Update tui test.

commit 08938bd
Author: Hilary James Oliver <[email protected]>
Date:   Thu Dec 7 18:24:50 2023 +1300

    Tweak wording of set --help. [skip ci]

commit 6e0f050
Author: Hilary James Oliver <[email protected]>
Date:   Thu Dec 7 16:30:12 2023 +1300

    Don't spawn parentless if removing after flow-stop.

commit 452c05d
Author: Hilary James Oliver <[email protected]>
Date:   Thu Dec 7 14:30:36 2023 +1300

    New func test.

commit b22b817
Author: Hilary James Oliver <[email protected]>
Date:   Thu Dec 7 14:29:59 2023 +1300

    Handle removal of parentless runahead tasks.

commit d9be15c
Author: Hilary James Oliver <[email protected]>
Date:   Wed Dec 6 19:41:43 2023 +1300

    Remove useless func test.

commit 69f2923
Author: Hilary James Oliver <[email protected]>
Date:   Wed Dec 6 18:51:04 2023 +1300

    Record task completion in DB, for spawning.

commit a66b50e
Author: Hilary James Oliver <[email protected]>
Date:   Wed Dec 6 18:09:28 2023 +1300

    Separate flows_nums stringify function.

commit 759faf9
Author: Hilary James Oliver <[email protected]>
Date:   Wed Dec 6 13:04:36 2023 +1300

    Fix some func tests.

commit 365a9c7
Author: Hilary James Oliver <[email protected]>
Date:   Wed Dec 6 12:17:41 2023 +1300

    expired tasks: dequeue and don't log as incomplete

commit acefbba
Author: Hilary James Oliver <[email protected]>
Date:   Tue Dec 5 17:21:58 2023 +1300

    Better handling of implied outputs.

commit 9fa07f9
Author: Hilary James Oliver <[email protected]>
Date:   Mon Dec 4 15:41:07 2023 +1300

    working on tui test...

commit 9702fd8
Author: Hilary James Oliver <[email protected]>
Date:   Mon Dec 4 14:42:28 2023 +1300

    Fix a tui test.

commit a79de36
Author: Hilary James Oliver <[email protected]>
Date:   Mon Dec 4 14:06:53 2023 +1300

    Simplify and tidy.

commit a7ee355
Author: Hilary James Oliver <[email protected]>
Date:   Mon Dec 4 10:42:28 2023 +1300

    mypy fix

commit cf197a1
Author: Hilary James Oliver <[email protected]>
Date:   Fri Dec 1 15:23:58 2023 +1300

    Add cylc-set func tests TEMP

commit d0e3c78
Author: Hilary James Oliver <[email protected]>
Date:   Thu Nov 23 13:29:19 2023 +1300

    cylc-set: glob in pool for now.

commit 78d5599
Author: Hilary James Oliver <[email protected]>
Date:   Sun Nov 19 11:40:59 2023 +1300

    Revert CI change.

commit ec954c2
Author: Hilary James Oliver <[email protected]>
Date:   Thu Nov 16 20:22:10 2023 +1300

    Fix command logging and test.

commit c61476f
Author: Hilary James Oliver <[email protected]>
Date:   Thu Nov 16 18:11:36 2023 +1300

    set command: dead end, not alias.

commit 6c308d8
Author: Hilary James Oliver <[email protected]>
Date:   Wed Nov 15 15:32:05 2023 +1300

    cylc set --pre: infer succeeded

commit 44d84df
Author: Hilary James Oliver <[email protected]>
Date:   Wed Nov 15 15:08:45 2023 +1300

    Clean up command logging.

commit cf8a26a
Author: Oliver Sanders <[email protected]>
Date:   Tue Nov 14 14:48:41 2023 +0000

    completion_server: support "cylc set" arguments

    * Support the `--pre` and `--out` arguments to `cylc set`.
    * This requires the task ID(s) to be provided *before* the `--pre` /
      `--out` option because otherwise we don't have the required
      information to complete the arguments.
    * This lists prereqs/outputs from `cylc show` which is currently
      restricted to n=1 tasks.
    * This does not support completing comma separared prereqs/outputs, use
      the `--pre` / `--out` options multiple times to do this.

commit a01a56b
Author: Hilary James Oliver <[email protected]>
Date:   Tue Nov 14 20:23:17 2023 +1300

    Fix simulation job stuff.

commit e81caf4
Author: Hilary James Oliver <[email protected]>
Date:   Tue Nov 14 18:34:51 2023 +1300

    Fix tests.

commit a7cbdd1
Author: Hilary James Oliver <[email protected]>
Date:   Tue Nov 14 16:14:48 2023 +1300

    Better command logging.

commit da2ced9
Author: Hilary James Oliver <[email protected]>
Date:   Tue Nov 14 15:30:53 2023 +1300

    Don't log state changes for transient tasks.

commit 34fc997
Author: Hilary James Oliver <[email protected]>
Date:   Tue Nov 14 10:35:34 2023 +1300

    Some fixes; and remove cylc-set functional tests.

commit 8acb090
Author: Hilary James Oliver <[email protected]>
Date:   Sun Nov 12 16:41:29 2023 +1300

    Add integration tests.

commit eac5276
Author: Hilary James Oliver <[email protected]>
Date:   Sun Nov 12 09:42:48 2023 +1300

    Clean up future trigger comments.

commit ba759c9
Author: Hilary James Oliver <[email protected]>
Date:   Sat Nov 11 23:04:24 2023 +1300

    tiny docstring tweak

commit c100520
Author: Hilary James Oliver <[email protected]>
Date:   Sat Nov 11 15:12:56 2023 +1300

    cylc-set doctests

commit 93152f2
Author: Hilary James Oliver <[email protected]>
Date:   Sat Nov 11 15:01:33 2023 +1300

    Handle missed started events.

commit 799f6ff
Author: Hilary James Oliver <[email protected]>
Date:   Sat Nov 11 13:57:13 2023 +1300

    Remove duplicate blocks, post merge from master.

commit 8cea473
Author: Hilary James Oliver <[email protected]>
Date:   Fri Nov 10 10:36:17 2023 +1300

    Squash "cylc set" dev branch. (History too messy!)
hjoliver added a commit that referenced this pull request Jan 18, 2024
@hjoliver
Squashed commit of the following:
366616c 
commit a3da49837f2b60e768784c416c511fe1d1b6d720
Merge: e793ca1 c07392d
Author: Hilary James Oliver <[email protected]>
Date:   Tue Jan 16 15:32:58 2024 +1300

    Merge branch 'master' into cylc-set-task

commit e793ca1
Author: Hilary James Oliver <[email protected]>
Date:   Tue Dec 19 17:49:33 2023 +1300

    working on flow_wait reset ...[skip ci]

commit f6a4f33
Author: Hilary James Oliver <[email protected]>
Date:   Tue Dec 19 15:46:11 2023 +1300

    Handle flow-number skipping.

commit 2f8536a
Merge: 3fddad0 ca8637e
Author: Hilary James Oliver <[email protected]>
Date:   Tue Dec 19 12:12:41 2023 +1300

    Merge pull request #35 from oliver-sanders/cylc-set-stuff

    Cylc set stuff

commit ca8637e
Author: Hilary James Oliver <[email protected]>
Date:   Tue Dec 19 12:12:19 2023 +1300

    Apply suggestions from code review [skip ci]

commit 3fddad0
Author: Hilary James Oliver <[email protected]>
Date:   Sun Dec 17 13:05:48 2023 +1300

    Fix wrong-outputs warning.

commit 7c75fbc
Author: Oliver Sanders <[email protected]>
Date:   Fri Dec 15 10:28:35 2023 +0000

    tui: support the "cylc set" command with default opts

commit cd4a3e3
Author: Oliver Sanders <[email protected]>
Date:   Fri Dec 15 10:18:49 2023 +0000

    set: add note about CLI completion

commit 06fbdea
Author: Hilary James Oliver <[email protected]>
Date:   Fri Dec 15 16:24:39 2023 +1300

    Fix C7 back-compat task removal.

commit ad6e5d7
Merge: 9d320a5 6f62691
Author: Hilary James Oliver <[email protected]>
Date:   Fri Dec 15 15:32:00 2023 +1300

    Merge branch 'master' into cylc-set-task

commit 9d320a5
Author: Hilary James Oliver <[email protected]>
Date:   Fri Dec 15 13:43:05 2023 +1300

    Final functionality tweaks.

commit 8f5c0aa
Author: Hilary James Oliver <[email protected]>
Date:   Thu Dec 14 21:33:08 2023 +1300

    Fix select prev instance from task_states table.

commit 8c34c75
Author: Hilary James Oliver <[email protected]>
Date:   Thu Dec 14 17:50:41 2023 +1300

    Fix functional tests.

commit e65f2c6
Author: Hilary James Oliver <[email protected]>
Date:   Thu Dec 14 16:37:24 2023 +1300

    Logging tweaks.

commit 1148487
Author: Hilary James Oliver <[email protected]>
Date:   Thu Dec 14 16:15:10 2023 +1300

    Fix an integration test.

commit 50a5b49
Author: Hilary James Oliver <[email protected]>
Date:   Thu Dec 14 15:55:34 2023 +1300

    Transient task proxy comment.

commit 4dc5a55
Author: Hilary James Oliver <[email protected]>
Date:   Thu Dec 14 10:40:46 2023 +1300

    Tweak satisfy_me methods.

commit cceb740
Author: Hilary James Oliver <[email protected]>
Date:   Thu Dec 14 10:10:17 2023 +1300

    Remove duplicate block.

commit 6503ac5
Author: Hilary James Oliver <[email protected]>
Date:   Wed Dec 13 16:29:24 2023 +1300

    Demote warning to debug.

commit 70fd970
Author: Hilary James Oliver <[email protected]>
Date:   Tue Dec 12 22:25:10 2023 +1300

    Code review tweaks 2.

commit 1e93707
Author: Hilary James Oliver <[email protected]>
Date:   Tue Dec 12 16:03:40 2023 +1300

    Update cylc/flow/task_pool.py [skip ci]

    Co-authored-by: Oliver Sanders <[email protected]>

commit 9c8b64a
Author: Hilary James Oliver <[email protected]>
Date:   Tue Dec 12 15:29:33 2023 +1300

    Update cylc/flow/task_proxy.py [skip ci]

    Co-authored-by: Oliver Sanders <[email protected]>

commit f592516
Author: Hilary James Oliver <[email protected]>
Date:   Tue Dec 12 13:23:00 2023 +1300

    code review tweaks [skip ci]

commit d2839b4
Author: Hilary James Oliver <[email protected]>
Date:   Fri Dec 8 14:32:48 2023 +1300

    Update tui test.

commit 08938bd
Author: Hilary James Oliver <[email protected]>
Date:   Thu Dec 7 18:24:50 2023 +1300

    Tweak wording of set --help. [skip ci]

commit 6e0f050
Author: Hilary James Oliver <[email protected]>
Date:   Thu Dec 7 16:30:12 2023 +1300

    Don't spawn parentless if removing after flow-stop.

commit 452c05d
Author: Hilary James Oliver <[email protected]>
Date:   Thu Dec 7 14:30:36 2023 +1300

    New func test.

commit b22b817
Author: Hilary James Oliver <[email protected]>
Date:   Thu Dec 7 14:29:59 2023 +1300

    Handle removal of parentless runahead tasks.

commit d9be15c
Author: Hilary James Oliver <[email protected]>
Date:   Wed Dec 6 19:41:43 2023 +1300

    Remove useless func test.

commit 69f2923
Author: Hilary James Oliver <[email protected]>
Date:   Wed Dec 6 18:51:04 2023 +1300

    Record task completion in DB, for spawning.

commit a66b50e
Author: Hilary James Oliver <[email protected]>
Date:   Wed Dec 6 18:09:28 2023 +1300

    Separate flows_nums stringify function.

commit 759faf9
Author: Hilary James Oliver <[email protected]>
Date:   Wed Dec 6 13:04:36 2023 +1300

    Fix some func tests.

commit 365a9c7
Author: Hilary James Oliver <[email protected]>
Date:   Wed Dec 6 12:17:41 2023 +1300

    expired tasks: dequeue and don't log as incomplete

commit acefbba
Author: Hilary James Oliver <[email protected]>
Date:   Tue Dec 5 17:21:58 2023 +1300

    Better handling of implied outputs.

commit 9fa07f9
Author: Hilary James Oliver <[email protected]>
Date:   Mon Dec 4 15:41:07 2023 +1300

    working on tui test...

commit 9702fd8
Author: Hilary James Oliver <[email protected]>
Date:   Mon Dec 4 14:42:28 2023 +1300

    Fix a tui test.

commit a79de36
Author: Hilary James Oliver <[email protected]>
Date:   Mon Dec 4 14:06:53 2023 +1300

    Simplify and tidy.

commit a7ee355
Author: Hilary James Oliver <[email protected]>
Date:   Mon Dec 4 10:42:28 2023 +1300

    mypy fix

commit cf197a1
Author: Hilary James Oliver <[email protected]>
Date:   Fri Dec 1 15:23:58 2023 +1300

    Add cylc-set func tests TEMP

commit d0e3c78
Author: Hilary James Oliver <[email protected]>
Date:   Thu Nov 23 13:29:19 2023 +1300

    cylc-set: glob in pool for now.

commit 78d5599
Author: Hilary James Oliver <[email protected]>
Date:   Sun Nov 19 11:40:59 2023 +1300

    Revert CI change.

commit ec954c2
Author: Hilary James Oliver <[email protected]>
Date:   Thu Nov 16 20:22:10 2023 +1300

    Fix command logging and test.

commit c61476f
Author: Hilary James Oliver <[email protected]>
Date:   Thu Nov 16 18:11:36 2023 +1300

    set command: dead end, not alias.

commit 6c308d8
Author: Hilary James Oliver <[email protected]>
Date:   Wed Nov 15 15:32:05 2023 +1300

    cylc set --pre: infer succeeded

commit 44d84df
Author: Hilary James Oliver <[email protected]>
Date:   Wed Nov 15 15:08:45 2023 +1300

    Clean up command logging.

commit cf8a26a
Author: Oliver Sanders <[email protected]>
Date:   Tue Nov 14 14:48:41 2023 +0000

    completion_server: support "cylc set" arguments

    * Support the `--pre` and `--out` arguments to `cylc set`.
    * This requires the task ID(s) to be provided *before* the `--pre` /
      `--out` option because otherwise we don't have the required
      information to complete the arguments.
    * This lists prereqs/outputs from `cylc show` which is currently
      restricted to n=1 tasks.
    * This does not support completing comma separared prereqs/outputs, use
      the `--pre` / `--out` options multiple times to do this.

commit a01a56b
Author: Hilary James Oliver <[email protected]>
Date:   Tue Nov 14 20:23:17 2023 +1300

    Fix simulation job stuff.

commit e81caf4
Author: Hilary James Oliver <[email protected]>
Date:   Tue Nov 14 18:34:51 2023 +1300

    Fix tests.

commit a7cbdd1
Author: Hilary James Oliver <[email protected]>
Date:   Tue Nov 14 16:14:48 2023 +1300

    Better command logging.

commit da2ced9
Author: Hilary James Oliver <[email protected]>
Date:   Tue Nov 14 15:30:53 2023 +1300

    Don't log state changes for transient tasks.

commit 34fc997
Author: Hilary James Oliver <[email protected]>
Date:   Tue Nov 14 10:35:34 2023 +1300

    Some fixes; and remove cylc-set functional tests.

commit 8acb090
Author: Hilary James Oliver <[email protected]>
Date:   Sun Nov 12 16:41:29 2023 +1300

    Add integration tests.

commit eac5276
Author: Hilary James Oliver <[email protected]>
Date:   Sun Nov 12 09:42:48 2023 +1300

    Clean up future trigger comments.

commit ba759c9
Author: Hilary James Oliver <[email protected]>
Date:   Sat Nov 11 23:04:24 2023 +1300

    tiny docstring tweak

commit c100520
Author: Hilary James Oliver <[email protected]>
Date:   Sat Nov 11 15:12:56 2023 +1300

    cylc-set doctests

commit 93152f2
Author: Hilary James Oliver <[email protected]>
Date:   Sat Nov 11 15:01:33 2023 +1300

    Handle missed started events.

commit 799f6ff
Author: Hilary James Oliver <[email protected]>
Date:   Sat Nov 11 13:57:13 2023 +1300

    Remove duplicate blocks, post merge from master.

commit 8cea473
Author: Hilary James Oliver <[email protected]>
Date:   Fri Nov 10 10:36:17 2023 +1300

    Squash "cylc set" dev branch. (History too messy!)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjoliver hjoliver hjoliver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliver-sanders @hjoliver