Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Testing #50

Conversation

wxtim
Copy link

@wxtim wxtim commented Apr 30, 2024

  • Added some more info to the docstrings of cylc/flow/dbstatecheck.py.
  • Added an xtrigger validation check for negative flow numbers.
  • Added full coverage unit tests for the xtrigger's validation function [1].

[1] Additionally tested as follows (but didn't fancy adding a new dependency):

from hypothesis import given
from hypothesis.strategies import integers, text


@given(output=text(), flownum=integers(min_value=0))
def test_validate_strange(flownum, output):
    args = {'output': output, 'status': None, 'flow_num': flownum}
    validate(args)

@wxtim wxtim force-pushed the fix-workflow-state-check.tests branch from 4da846f to e1a4445 Compare May 1, 2024 07:32
assert result == expect


def test_output(checker):
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wxtim wxtim marked this pull request as draft May 2, 2024 08:02
@wxtim
Copy link
Author

wxtim commented May 2, 2024

converted to draft as it's parent PR branch.

@hjoliver hjoliver force-pushed the fix-workflow-state-check branch 2 times, most recently from 942c8c1 to 67b415b Compare May 3, 2024 03:54
@hjoliver hjoliver force-pushed the fix-workflow-state-check branch 3 times, most recently from a517b41 to 7772bbc Compare May 20, 2024 04:53
@hjoliver hjoliver force-pushed the fix-workflow-state-check branch 4 times, most recently from 793be47 to 2e70e43 Compare May 27, 2024 22:14
@hjoliver hjoliver force-pushed the fix-workflow-state-check branch from 77c44bd to 960fb61 Compare June 5, 2024 07:00
@hjoliver hjoliver force-pushed the fix-workflow-state-check branch from 03def55 to a17959e Compare June 12, 2024 05:17
@wxtim
Copy link
Author

wxtim commented Jun 12, 2024

So far diverged from orig branch that it's not worth keeping. May pick some stuff out on reviewing target.

@wxtim wxtim closed this Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants