forked from cylc/cylc-flow
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Testing #50
Closed
wxtim
wants to merge
15
commits into
hjoliver:fix-workflow-state-check
from
wxtim:fix-workflow-state-check.tests
Closed
[WIP] Testing #50
wxtim
wants to merge
15
commits into
hjoliver:fix-workflow-state-check
from
wxtim:fix-workflow-state-check.tests
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ronnie Dutta <[email protected]>
Co-authored-by: Ronnie Dutta <[email protected]>
8 tasks
wxtim
force-pushed
the
fix-workflow-state-check.tests
branch
from
May 1, 2024 07:32
4da846f
to
e1a4445
Compare
to facilitate testing.
Write a basic test for CylcWorkflowDBChecker.workflow_state
wxtim
commented
May 1, 2024
assert result == expect | ||
|
||
|
||
def test_output(checker): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indicates this https://github.com/cylc/cylc-flow/pull/5809/files#r1586443251 breakage
converted to draft as it's parent PR branch. |
hjoliver
force-pushed
the
fix-workflow-state-check
branch
2 times, most recently
from
May 3, 2024 03:54
942c8c1
to
67b415b
Compare
hjoliver
force-pushed
the
fix-workflow-state-check
branch
3 times, most recently
from
May 20, 2024 04:53
a517b41
to
7772bbc
Compare
hjoliver
force-pushed
the
fix-workflow-state-check
branch
4 times, most recently
from
May 27, 2024 22:14
793be47
to
2e70e43
Compare
hjoliver
force-pushed
the
fix-workflow-state-check
branch
from
June 5, 2024 07:00
77c44bd
to
960fb61
Compare
hjoliver
force-pushed
the
fix-workflow-state-check
branch
from
June 12, 2024 05:17
03def55
to
a17959e
Compare
So far diverged from orig branch that it's not worth keeping. May pick some stuff out on reviewing target. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cylc/flow/dbstatecheck.py
.[1] Additionally tested as follows (but didn't fancy adding a new dependency):