Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

35 Add Observation-glasgow-coma-scale.json as example of au-core-disagnoticresult with components #51

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

heathfrankel
Copy link
Collaborator

@heathfrankel heathfrankel commented Sep 25, 2024

Add Observation-glasgow-coma-scale.json as example of au-core-disagnoticresult with components

The generated Observation-glasgow-coma-scale.json currently fails upload to CDR due to missing {scale} code in UCUM fragment.

@heathfrankel
Copy link
Collaborator Author

This PR includes changes in #50, which should be merged first.
This was done to avoid conflicts on the Observation.csv

@StephThaoOng
Copy link
Collaborator

Hey @heathfrankel, while reviewing your PR, I'd suggest the following code changes:

👉 Code Suggestion for #51

#51
Hi Heath,
Review completed and pending UCUM fragment fix noted.
Suggested changes:

  1. I'm unsure about the use of the AU Core Diagnostic Result Observation profile for a GCS assessment. Representing GCS score/assessment as base Observation seems more appropriate. Heather Leslie agrees with representation as on Observation and avoiding the 'diagnostic' label. Having said that and noting that meta.profile is for stating resource profile conformance, I wonder if we could populate meta.profile with both
  1. I think it would be useful to include the individual GCS component numerical scores that add up to the total score.
  2. referenceRange should include the ranges for mild, moderate and sever TBI.

You can also review and apply these suggestions locally on your machine.

Learn more about GitKraken Code Suggest

Code Suggest liberates your code reviews from GitHub's restrictive, comment-only feedback style. As simple as suggesting changes in a Google-doc, provide real code suggestions from where you code, e.g. your IDE, and on anything in your project — not just on the lines of code changed in the PR.

Join your team on GitKraken to speed up PR review.

@heathfrankel
Copy link
Collaborator Author

@StephThaoOng my response below:

  1. as you say, meta.profile is more the structural conformance than semantic label, and in principle this exam/assessment has the same structural pattern. There is no existing observation profile to use, and Observation is inherit in the specified profile/resourceType. If someone can suggest/provide a better example of a diagnostic result with components I am more than happy to change this GCS example to a different profile (not that there is one in AU Core/Base).
    Would visual acuity be a candidate?
  2. We can look at including the ordinal extension values associated with the component value coding elements, but this is beyond the AU Core profile and might just complicate the example too much at this stage. Happy to add if required.
  3. Only the applicable reference range was provided due to a limitation in the current columns in the spreadsheet and mapping. Happy to add if required.

Should we raise a new github card for these suggested changes for future consideration?

@heathfrankel heathfrankel merged commit cf9d56c into master Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enrich Observation Diagnostic Result resources with 'Must Support' data
2 participants