Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: update packages #107

Merged
merged 9 commits into from
Nov 22, 2023
Merged

chore!: update packages #107

merged 9 commits into from
Nov 22, 2023

Conversation

saul-jb
Copy link
Contributor

@saul-jb saul-jb commented Nov 20, 2023

This PR updates all the libp2p related packages to make it work with the newer versions of libp2p.

  • Fixes the silent bootstrap replicator fail with the new Libp2p.

The breaking changes is the libp2p streams interface that has changed - as far as I can tell this only breaks the bootstrap replicator.

Copy link
Member

@tabcat tabcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 just the one comment and we can get this merged 💯

Also, wondering if it was necessary to bump zzzync with the libp2p bump

test/utils/libp2p-services.ts Outdated Show resolved Hide resolved
@saul-jb
Copy link
Contributor Author

saul-jb commented Nov 20, 2023

Also, wondering if it was necessary to bump zzzync with the libp2p bump

Yeah, the old zzzync uses the older interfaces which were giving errors.

@tabcat tabcat merged commit 0472efd into hldb:master Nov 22, 2023
4 checks passed
@tabcat
Copy link
Member

tabcat commented Nov 22, 2023

plan to refactor tests and test utils in the future so everything is less flaky, already started #103 but thinking about refactoring code first and closing that PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants