Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement product opco cards #566

Merged
merged 4 commits into from
Dec 11, 2023
Merged

feat: implement product opco cards #566

merged 4 commits into from
Dec 11, 2023

Conversation

duynguyen
Copy link
Collaborator

Copy link
Contributor

aem-code-sync bot commented Dec 8, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

Copy link
Contributor

aem-code-sync bot commented Dec 8, 2023

Page Scores Audits Google
/us/en/product1 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Collaborator

@davenichols-DHLS davenichols-DHLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cards look good to me, happy if the others are.

@rgravitvl
Copy link
Collaborator

rgravitvl commented Dec 9, 2023

@duynguyen the height of the title block is bit high, may be we can reduce that, left border needs to be added and link color to be changed as well. Rest looks good to me, Thanks.

image image

@duynguyen
Copy link
Collaborator Author

@rgravitvl the styling you see on this page https://508--danaher-ls-aem--hlxsites.hlx.page/us/en/product1 is the old one. This PR also comes with the new styles but you need to run the converter locally to see it.

Regarding the space of the title block, because there are some titles that span 2 lines, it looks better to leave a bit of space to align the description on the same line. Otherwise the description blocks are misaligned.

Screenshot 2023-12-11 at 11 00 30

@davenichols-DHLS davenichols-DHLS merged commit 16ae039 into main Dec 11, 2023
3 checks passed
@davenichols-DHLS davenichols-DHLS deleted the 508 branch December 11, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Product Home] OpCo Cards block
4 participants