-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement product opco cards #566
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cards look good to me, happy if the others are.
@duynguyen the height of the title block is bit high, may be we can reduce that, left border needs to be added and link color to be changed as well. Rest looks good to me, Thanks. |
@rgravitvl the styling you see on this page https://508--danaher-ls-aem--hlxsites.hlx.page/us/en/product1 is the old one. This PR also comes with the new styles but you need to run the converter locally to see it. Regarding the space of the title block, because there are some titles that span 2 lines, it looks better to leave a bit of space to align the description on the same line. Otherwise the description blocks are misaligned. |
Fix #508
Test URLs: