Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

637 Updated converter product detail page #638

Merged
merged 5 commits into from
Jan 4, 2024
Merged

637 Updated converter product detail page #638

merged 5 commits into from
Jan 4, 2024

Conversation

rgravitvl
Copy link
Collaborator

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #637

Test URLs:

@rgravitvl rgravitvl linked an issue Jan 3, 2024 that may be closed by this pull request
[Product] Converter update product detail page #637
Closed
@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Jan 3, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Jan 3, 2024 •
edited
Loading

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

davenichols-DHLS
davenichols-DHLS approved these changes Jan 3, 2024
View reviewed changes
Copy link
Collaborator

@davenichols-DHLS davenichols-DHLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but @mhaack should probably review.

@aem-code-sync aem-code-sync bot temporarily deployed to 637-converter-update-product-page January 4, 2024 04:38 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 637-converter-update-product-page January 4, 2024 11:07 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 637-converter-update-product-page January 4, 2024 11:16 Inactive
@rgravitvl rgravitvl requested a review from mhaack January 4, 2024 11:16
@rgravitvl rgravitvl merged commit 6889219 into main Jan 4, 2024
3 checks passed
@rgravitvl rgravitvl deleted the 637-converter-update-product-page branch January 4, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davenichols-DHLS davenichols-DHLS davenichols-DHLS approved these changes

@duynguyen duynguyen duynguyen approved these changes

@sharanagoudapatil sharanagoudapatil Awaiting requested review from sharanagoudapatil

@amlan18041996 amlan18041996 Awaiting requested review from amlan18041996

@mhaack mhaack Awaiting requested review from mhaack

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Product] Converter update product detail page
4 participants
@rgravitvl @duynguyen @mhaack @davenichols-DHLS