Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] carousel 'View Product' button broken #764

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

sharanagoudapatil
Copy link
Collaborator

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #758

Test URLs:

Copy link
Contributor

aem-code-sync bot commented Feb 7, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Feb 7, 2024

Page Scores Audits Google
/us/en/products PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Collaborator

@davenichols-DHLS davenichols-DHLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thank you @sharanagoudapatil , but sorry can you make one small change, on the button classes:

btn btn-lg btn-primary-purple rounded-full px-6

Can you please add:

mt-10

Copy link
Collaborator

@davenichols-DHLS davenichols-DHLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, thank you for looking into this.

@davenichols-DHLS davenichols-DHLS merged commit b3619a2 into main Feb 7, 2024
2 checks passed
@davenichols-DHLS davenichols-DHLS deleted the 758-carousel-btn-broken branch February 7, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] carousel 'View Product' button broken?
2 participants