Improve resilience when potential missing props, fix unit tests

hmcts · Nov 6, 2024 · 718ab59 · 718ab59
1 parent 0c140fe
commit 718ab59
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/...it/src/lib/shared/components/palette/base-field/abstract-field-write-journey.component.ts b/...it/src/lib/shared/components/palette/base-field/abstract-field-write-journey.component.ts
@@ -43,7 +43,7 @@ export abstract class AbstractFieldWriteJourneyComponent extends AbstractFieldWr
 
     protected previousPage(): void {
       if (this.hasPrevious()) {
-        if (!this.childJourney['searchLanguageInterpreterHint']){
+        if (!this.childJourney?.searchLanguageInterpreterHint){
           this.journeyPageNumber--;
         }
         this.onPageChange();
@@ -52,7 +52,7 @@ export abstract class AbstractFieldWriteJourneyComponent extends AbstractFieldWr
 
     protected nextPage(): void {
       if (this.hasNext()) {
-        if (!this.childJourney['searchLanguageInterpreterHint']){
+        if (!this.childJourney?.searchLanguageInterpreterHint){
           this.journeyPageNumber++;
         }
         this.onPageChange();

diff --git a/...ed/components/palette/case-flag/components/select-flag-type/select-flag-type.component.ts b/...ed/components/palette/case-flag/components/select-flag-type/select-flag-type.component.ts
@@ -183,8 +183,8 @@ export class SelectFlagTypeComponent extends AbstractJourneyComponent implements
     } else {
       // this code will run only when the sub journey is complete
       const currentSelectedFlag = this.formGroup.controls.flagType;
-      const addedFlagValue = this.selectedFlagsLocation['caseField'].value.details;
-      if (addedFlagValue[Object.keys(addedFlagValue).length]?.name !== currentSelectedFlag.value.name) {
+      const addedFlagValue = this.selectedFlagsLocation?.caseField?.value?.details;
+      if (addedFlagValue && (addedFlagValue[Object.keys(addedFlagValue).length]?.name !== currentSelectedFlag.value.name)) {
         this.selectedFlagsLocation['caseField'].value.details.pop();
         this.selectedFlagsLocation['caseField'].formatted_value?.details.pop();
       }

diff --git a/projects/ccd-case-ui-toolkit/src/lib/shared/domain/journey/journey.model.ts b/projects/ccd-case-ui-toolkit/src/lib/shared/domain/journey/journey.model.ts
@@ -14,4 +14,5 @@ export interface Journey {
     childJourney: Journey;
     fieldState?: number;
     linkedCasesPage?: number;
+    searchLanguageInterpreterHint?;
 }