-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ReasonML edition. #247
ReasonML edition. #247
Conversation
Oh wow! This is great, thank you :) |
Of course. @yawaramin @mlms13 @andywhite37 @Risto-Stevcev |
@fhammerschmidt - this is really cool! I've been meaning to check out this book, so this is a good excuse. I don't know if I'll have time to do a thorough review, but the stuff I saw at a quick glance looked good. |
@@ -0,0 +1,6 @@ | |||
module type Polymorphic_Function_F = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think these module types make it easy to understand if you are not very experienced with reason. I see in Yawar's PR to the ocaml version he also simplified it.
I guess it isn't correct to say let f: a => b;
alone, but for pedagogical reasons I feel it is better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will update accordingly when his PR gets merged.
Can we please merge this? It's probably not perfect for now, because I am still waiting for #242 to adapt, but I think it is better to have the bulk merged now. |
We need to also update the Github actions workflow to include this new edition. |
Yeah, very sorry for neglecting! :( |
84cf2cc
to
a537ebd
Compare
Rebased and added Reason to workflows: a537ebd |
Amazing, let's do this! 🎉 |
Thanks all very much for your contributions!! |
I converted the OCaml edition thanks to the Reason parser which can translate OCaml into Reason source code (and vice versa). Not everything did compile or typecheck, so there was still some manual work necessary.
I figured if I wanted to learn category theory, I'd rather do this in my everyday language so here's the ReasonML edition of CTFP!