DAC6-3338: Change Verifiers for individuals #146
Merged
+49
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored SubscriptionInfo to include individual registration address information. Added tests to verify the inclusion of postcode and abroad flag for individual (Ind) registration info.
C-Thomp
previously approved these changes
Nov 7, 2024
Refactored address handling logic for clearer code and added country information to address instances in unit tests. Introduced a helper method to centralize address retrieval from user answers and simplified conditional checks using the new method.
C-Thomp
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored SubscriptionInfo to include individual registration address information. Added tests to verify the inclusion of postcode and abroad flag for individual (Ind) registration info.