Misuv 6802: WIP / DNMerge / session service remove keys #2025

avelx · 2023-12-08T14:15:13Z

No description provided.

* Initial version

* test version: v1

platops-pr-bot · 2023-12-08T14:21:07Z

There is a bobby warning (builds will be prevented after 31 May 2024) - see the pr builder for details
Routes defined in conf/testOnlyDoNotUseInAppConf.routes should contain /test-only/ prefix

* current changes

* fix AddBusinessNameResponse and AddBusinessTradeNameResponse scenarios

platops-pr-bot · 2023-12-08T18:20:19Z

There is a bobby warning (builds will be prevented after 31 May 2024) - see the pr builder for details
Remove println(s"Here is journey type: ${journeyType}") from app/services/SessionService.scala
Remove println(s"Data ${data.addIncomeSourceData}") from app/services/SessionService.scala
Remove println(s"Data saving ") from app/services/SessionService.scala
Remove println(s"Data saved ...") from app/services/SessionService.scala
Routes defined in conf/testOnlyDoNotUseInAppConf.routes should contain /test-only/ prefix

* use typeTags to preserver info regarding required response data;

platops-pr-bot · 2023-12-08T18:46:26Z

~~Remove println(s"Here is journey type: ${journeyType}") from app/services/SessionService.scala~~
~~Remove println(s"Data ${data.addIncomeSourceData}") from app/services/SessionService.scala~~
There is a bobby warning (builds will be prevented after 31 May 2024) - see the pr builder for details
Remove println(s"Data saving ") from app/services/SessionService.scala
Remove println(s"Data saved ...") from app/services/SessionService.scala
Routes defined in conf/testOnlyDoNotUseInAppConf.routes should contain /test-only/ prefix

* move incomeSourceType to implicit's

platops-pr-bot · 2023-12-11T10:11:57Z

~~Remove println(s"Here is journey type: ${journeyType}") from app/services/SessionService.scala~~
~~Remove println(s"Data ${data.addIncomeSourceData}") from app/services/SessionService.scala~~
There is a bobby warning (builds will be prevented after 31 May 2024) - see the pr builder for details
Remove println(s"Data saving ") from app/services/SessionService.scala
Remove println(s"Data saved ...") from app/services/SessionService.scala
Routes defined in conf/testOnlyDoNotUseInAppConf.routes should contain /test-only/ prefix

* add new type: AddDateStartedAndAccMethodResponse

platops-pr-bot · 2023-12-11T11:55:06Z

~~Remove println(s"Here is journey type: ${journeyType}") from app/services/SessionService.scala~~
~~Remove println(s"Data ${data.addIncomeSourceData}") from app/services/SessionService.scala~~
There is a bobby warning (builds will be prevented after 31 May 2024) - see the pr builder for details
Remove println(s"Data saving ") from app/services/SessionService.scala
Remove println(s"Data saved ...") from app/services/SessionService.scala
Routes defined in conf/testOnlyDoNotUseInAppConf.routes should contain /test-only/ prefix

* code tidy up

platops-pr-bot · 2023-12-11T12:00:53Z

~~Remove println(s"Here is journey type: ${journeyType}") from app/services/SessionService.scala~~
~~Remove println(s"Data ${data.addIncomeSourceData}") from app/services/SessionService.scala~~
There is a bobby warning (builds will be prevented after 31 May 2024) - see the pr builder for details
Remove println(s"Data saving ") from app/services/SessionService.scala
Remove println(s"Data saved ...") from app/services/SessionService.scala
Routes defined in conf/testOnlyDoNotUseInAppConf.routes should contain /test-only/ prefix

* draft version of setMongoKeyTyped method

* code tidy up

platops-pr-bot · 2023-12-12T17:27:43Z

~~Remove println(s"Here is journey type: ${journeyType}") from app/services/SessionService.scala~~
~~Remove println(s"Data ${data.addIncomeSourceData}") from app/services/SessionService.scala~~
~~Remove println(s"Data saving ") from app/services/SessionService.scala~~
~~Remove println(s"Data saved ...") from app/services/SessionService.scala~~
There is a bobby warning (builds will be prevented after 31 May 2024) - see the pr builder for details
Routes defined in conf/testOnlyDoNotUseInAppConf.routes should contain /test-only/ prefix

avelx added 2 commits December 8, 2023 13:55

MISUV-6802:

776bb42

* Initial version

MISUV-6802:

9e916bf

* test version: v1

avelx added 2 commits December 8, 2023 18:09

MISUV-6802:

d184621

* current changes

MISUV-6802:

18d3233

* fix AddBusinessNameResponse and AddBusinessTradeNameResponse scenarios

MISUV-6802:

8c447d8

* use typeTags to preserver info regarding required response data;

MISUV-6802:

922ce0e

* move incomeSourceType to implicit's

MISUV-6802:

ba7a04a

* add new type: AddDateStartedAndAccMethodResponse

MISUV-6802:

cb1fae0

* code tidy up

avelx added 2 commits December 12, 2023 17:23

MISUV-6802:

3a010e7

* draft version of setMongoKeyTyped method

MISUV-6802:

653aa37

* code tidy up

Mbrookesy added PROTOTYPE Don't merge!!! labels Oct 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Misuv 6802: WIP / DNMerge / session service remove keys #2025

Misuv 6802: WIP / DNMerge / session service remove keys #2025

avelx commented Dec 8, 2023

platops-pr-bot commented Dec 8, 2023

platops-pr-bot commented Dec 8, 2023

platops-pr-bot commented Dec 8, 2023

platops-pr-bot commented Dec 11, 2023

platops-pr-bot commented Dec 11, 2023

platops-pr-bot commented Dec 11, 2023

platops-pr-bot commented Dec 12, 2023

Misuv 6802: WIP / DNMerge / session service remove keys #2025

Are you sure you want to change the base?

Misuv 6802: WIP / DNMerge / session service remove keys #2025

Conversation

avelx commented Dec 8, 2023

platops-pr-bot commented Dec 8, 2023

platops-pr-bot commented Dec 8, 2023

platops-pr-bot commented Dec 8, 2023

platops-pr-bot commented Dec 11, 2023

platops-pr-bot commented Dec 11, 2023

platops-pr-bot commented Dec 11, 2023

platops-pr-bot commented Dec 12, 2023