Merge pull request #945 from hmrc/DL-8900

DL-8900 - Removal of not needed data
hmrc · Oct 18, 2022 · 12e0f6e · 12e0f6e
2 parents 5ecf8cd + 6079fa4
commit 12e0f6e
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 10 deletions.
diff --git a/app/v1/models/response/financialData/FinancialDataResponse.scala b/app/v1/models/response/financialData/FinancialDataResponse.scala
@@ -56,7 +56,6 @@ case class DocumentDetail(postingDate: Option[String],
                           documentClearedAmount: Option[BigDecimal],
                           documentInterestTotals: Option[DocumentInterestTotals],
                           documentOutstandingAmount: Option[BigDecimal],
-                          documentInterestTotal: Option[BigDecimal],
                           lineItemDetails: Option[Seq[LineItemDetail]])
 
 object DocumentDetail {
@@ -67,7 +66,6 @@ object DocumentDetail {
       (JsPath \ "documentClearedAmount").readNullable[BigDecimal] and
       (JsPath \ "documentInterestTotals").readNullable[DocumentInterestTotals] and
       (JsPath \ "documentOutstandingAmount").readNullable[BigDecimal] and
-      (JsPath \ "documentInterestTotals" \ "interestTotalAmount").readNullable[BigDecimal] and
       (JsPath \ "lineItemDetails").readNullable[Seq[LineItemDetail]]
     )(DocumentDetail.apply _)
 

diff --git a/resources/public/api/conf/1.0/examples/penalties/FinancialDetails.json b/resources/public/api/conf/1.0/examples/penalties/FinancialDetails.json
@@ -21,7 +21,6 @@
         "interestPostedAmount": 13.12,
         "interestAccruingAmount": 12.10
       },
-      "documentInterestTotal": 1.23,
       "lineItemDetails": [
         {
           "chargeDescription": "VAT Return",

diff --git a/resources/public/api/conf/1.0/schemas/penalties/FinancialDetails.json b/resources/public/api/conf/1.0/schemas/penalties/FinancialDetails.json
@@ -100,11 +100,6 @@
             "type": "number",
             "example": "5009.99"
           },
-          "documentInterestTotal": {
-            "description": "The total amount of interest that is associated with the document. The value must be between -99999999999.99 and 99999999999.99 to 2 decimal places.",
-            "type": "number",
-            "example": "5009.99"
-          },
           "lineItemDetails": {
             "description": "The line items that make up the document. A document can contain more than one line item. For example, an individual or organisation might submit an amendment form that contains multiple corrections (perhaps the individual or organisation paid too much VAT for one tax period, but not enough for the next). Each correction will comprise an individual line item. HMRC will take all of the line items into account when it calculates the charge.",
             "type": "array",

diff --git a/test/v1/constants/FinancialDataConstants.scala b/test/v1/constants/FinancialDataConstants.scala
@@ -191,7 +191,6 @@ object FinancialDataConstants {
         |      },
         |      "documentClearedAmount": 111.11,
         |      "documentOutstandingAmount": 12.34,
-        |      "documentInterestTotal": 1.23,
         |      "lineItemDetails": [
         |        {
         |          "chargeDescription": "IN1",
@@ -247,7 +246,6 @@ object FinancialDataConstants {
     documentClearedAmount = Some(111.11),
     documentInterestTotals = Some(testDocumentInterestTotals),
     documentOutstandingAmount = Some(12.34),
-    documentInterestTotal = Some(1.23),
     lineItemDetails = Some(Seq(testLineItemDetails))
   )