Merge pull request #966 from hmrc/DL-9192

[DL-9192] - update upstream appealStatus values
hmrc · Dec 12, 2022 · 7fd5725 · 7fd5725
2 parents e1f9e5d + d19e771
commit 7fd5725
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 14 deletions.
diff --git a/app/v1/models/response/penalties/AppealStatusDownstream.scala b/app/v1/models/response/penalties/AppealStatusDownstream.scala
@@ -25,19 +25,19 @@ sealed trait AppealStatusDownstream {
 
 object AppealStatusDownstream {
   case object `A` extends AppealStatusDownstream {
-    override def toUpstreamAppealStatus: AppealStatusUpstream = AppealStatusUpstream.`under appeal`
+    override def toUpstreamAppealStatus: AppealStatusUpstream = AppealStatusUpstream.`under-appeal`
   }
 
   case object `B` extends AppealStatusDownstream {
-    override def toUpstreamAppealStatus: AppealStatusUpstream = AppealStatusUpstream.`appeal upheld`
+    override def toUpstreamAppealStatus: AppealStatusUpstream = AppealStatusUpstream.`appeal-upheld`
   }
 
   case object `C` extends AppealStatusDownstream {
-    override def toUpstreamAppealStatus: AppealStatusUpstream = AppealStatusUpstream.`appeal rejected`
+    override def toUpstreamAppealStatus: AppealStatusUpstream = AppealStatusUpstream.`appeal-rejected`
   }
 
   case object `99` extends AppealStatusDownstream {
-    override def toUpstreamAppealStatus: AppealStatusUpstream = AppealStatusUpstream.`cannot be appealed`
+    override def toUpstreamAppealStatus: AppealStatusUpstream = AppealStatusUpstream.`cannot-be-appealed`
   }
 
   implicit val format: json.Format[AppealStatusDownstream] = Enums.format[AppealStatusDownstream]

diff --git a/app/v1/models/response/penalties/AppealStatusUpstream.scala b/app/v1/models/response/penalties/AppealStatusUpstream.scala
@@ -24,19 +24,19 @@ sealed trait AppealStatusUpstream {
 }
 
 object AppealStatusUpstream {
-  case object `under appeal` extends AppealStatusUpstream {
+  case object `under-appeal` extends AppealStatusUpstream {
     override def toDownstreamAppealStatus: AppealStatusDownstream = AppealStatusDownstream.`A`
   }
 
-  case object `appeal upheld` extends AppealStatusUpstream {
+  case object `appeal-upheld` extends AppealStatusUpstream {
     override def toDownstreamAppealStatus: AppealStatusDownstream = AppealStatusDownstream.`B`
   }
 
-  case object `appeal rejected` extends AppealStatusUpstream {
+  case object `appeal-rejected` extends AppealStatusUpstream {
     override def toDownstreamAppealStatus: AppealStatusDownstream = AppealStatusDownstream.`C`
   }
 
-  case object `cannot be appealed` extends AppealStatusUpstream {
+  case object `cannot-be-appealed` extends AppealStatusUpstream {
     override def toDownstreamAppealStatus: AppealStatusDownstream = AppealStatusDownstream.`99`
   }
 

diff --git a/test/v1/constants/PenaltiesConstants.scala b/test/v1/constants/PenaltiesConstants.scala
@@ -95,7 +95,7 @@ object PenaltiesConstants {
       ))),
       appealInformation = Some(List(
         AppealInformation(
-          appealStatus = AppealStatusUpstream.`under appeal`,
+          appealStatus = AppealStatusUpstream.`under-appeal`,
           appealLevel = AppealLevelUpstream.`statutory-review`
         )
       )),
@@ -127,7 +127,7 @@ object PenaltiesConstants {
       penaltyChargeDueDate = Some("2022-10-11"),
       appealInformation = Some(Seq(
         AppealInformation(
-          appealStatus = AppealStatusUpstream.`under appeal`,
+          appealStatus = AppealStatusUpstream.`under-appeal`,
           appealLevel = AppealLevelUpstream.`statutory-review`
         )
       )),
@@ -257,7 +257,7 @@ object PenaltiesConstants {
       |            ],
       |            "appealInformation":[
       |               {
-      |                  "appealStatus":"under appeal",
+      |                  "appealStatus":"under-appeal",
       |                  "appealLevel":"statutory-review"
       |               }
       |            ],
@@ -288,7 +288,7 @@ object PenaltiesConstants {
        |            ],
        |            "appealInformation":[
        |               {
-       |                  "appealStatus":"under appeal",
+       |                  "appealStatus":"under-appeal",
        |                  "appealLevel":"statutory-review"
        |               }
        |            ],
@@ -402,7 +402,7 @@ object PenaltiesConstants {
         |    "penaltyChargeReference": "123",
         |    "penaltyChargeDueDate": "2022-10-11",
         |    "appealInformation": [{
-        |        "appealStatus":  "under appeal",
+        |        "appealStatus":  "under-appeal",
         |        "appealLevel": "statutory-review"
         |      }],
         |    "principalChargeDocNumber": "123",
@@ -436,7 +436,7 @@ object PenaltiesConstants {
         |    "penaltyChargeReference": "123",
         |    "penaltyChargeDueDate": "2022-10-11",
         |    "appealInformation": [{
-        |        "appealStatus":  "under appeal",
+        |        "appealStatus":  "under-appeal",
         |        "appealLevel": "statutory-review"
         |      }],
         |    "principalChargeDocNumber": "123",