Merge pull request #975 from hmrc/DL-9304

DL-9304 - Removal of periodKey and Interest
hmrc · Dec 20, 2022 · 8e912e7 · 8e912e7
2 parents bb3718b + 571d34f
commit 8e912e7
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 7 deletions.
diff --git a/app/v1/models/response/financialData/FinancialDataResponse.scala b/app/v1/models/response/financialData/FinancialDataResponse.scala
@@ -20,8 +20,7 @@ import play.api.libs.json._
 import v1.models.errors.MtdError
 import play.api.libs.functional.syntax._
 
-case class LineItemInterestDetails(interestKey: Option[String],
-                                   currentInterestRate: Option[BigDecimal],
+case class LineItemInterestDetails(currentInterestRate: Option[BigDecimal],
                                    interestPostedAmount: Option[BigDecimal],
                                    interestAccruingAmount: Option[BigDecimal],
                                    interestStartDate: Option[String])
@@ -34,7 +33,6 @@ case class LineItemDetail(
                           chargeDescription: Option[String],
                           periodFromDate: Option[String],
                           periodToDate: Option[String],
-                          periodKey: Option[String],
                           netDueDate: Option[String],
                           amount: Option[BigDecimal],
                           lineItemInterestDetails: Option[LineItemInterestDetails])

diff --git a/test/v1/constants/FinancialDataConstants.scala b/test/v1/constants/FinancialDataConstants.scala
@@ -200,11 +200,9 @@ object FinancialDataConstants {
         |          "chargeDescription": "IN1",
         |          "periodFromDate": "2022-03-01",
         |          "periodToDate": "2022-03-01",
-        |          "periodKey": "13RL",
         |          "netDueDate": "2022-03-01",
         |          "amount": 123.45,
         |          "lineItemInterestDetails": {
-        |            "interestKey": "01",
         |            "interestStartDate": "2022-03-01",
         |            "currentInterestRate": 2,
         |            "interestPostedAmount": 123,
@@ -220,7 +218,6 @@ object FinancialDataConstants {
   }
 
   val testLineItemInterestDetails: LineItemInterestDetails = LineItemInterestDetails(
-    interestKey = Some("01"),
     currentInterestRate = Some(2),
     interestPostedAmount = Some(123),
     interestAccruingAmount = Some(123),
@@ -231,7 +228,6 @@ object FinancialDataConstants {
     chargeDescription = Some("IN1"),
     periodFromDate = Some("2022-03-01"),
     periodToDate = Some("2022-03-01"),
-    periodKey = Some("13RL"),
     netDueDate = Some("2022-03-01"),
     amount = Some(123.45),
     lineItemInterestDetails = Some(testLineItemInterestDetails)