fix: set default threshold to 0.05

hokify · Feb 21, 2023 · 6c39fec · 6c39fec
1 parent 96050ec
commit 6c39fec
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/README.md b/README.md
@@ -28,7 +28,7 @@ The possible inputs for this action are:
 | `github-token` (**Required**)       | Github token used for posting the comment. To use the key provided by the GitHub action runner, use `${{ secrets.GITHUB_TOKEN }}`.                                           |         |
 | `monorepo-base-path` (**Required**) | The location of your monrepo `packages` path                                                                                                                                 |         |
 | `s3-config`                         | Configuration for uploading lcov files to s3. Json Encoded. e.g. '{ credentials: { accessKeyId: "", secretAccessKey: "" }, region: "", Bucket: "repository-code-coverage" }' |         |
-| `threshold`                         | Sets the threshold before the action fails if coverage of a package decreases                                                                                                | 0.1%    |
+| `threshold`                         | Sets the threshold before the action fails if coverage of a package decreases                                                                                                | 0.05%   |
 
 ## Examples
 

diff --git a/action.yml b/action.yml
@@ -15,7 +15,7 @@ inputs:
         description: 's3 config for lcov file storage, json encoded { credentials: { accessKeyId: "", secretAccessKey: "", }, region: "", Bucket: "repository-code-coverage" }'
         required: false
     threshold:
-        description: 'minimum threshold (in %) before the action fails, default is 0.1%'
+        description: 'minimum threshold (in %) before the action fails, default is 0.05%'
         required: false
 runs:
     using: node16

diff --git a/dist/index.js b/dist/index.js
diff --git a/src/app.ts b/src/app.ts
@@ -243,7 +243,7 @@ export async function generateReport(
     prNumber: number,
     base: string,
     mainBase = "master",
-    threshold = 0.1,
+    threshold = 0.05,
 ) {
     const [{ lcovArrayForMonorepo }, { lcovBaseArrayForMonorepo }] =
         await Promise.all([

diff --git a/src/cli.ts b/src/cli.ts
@@ -77,7 +77,7 @@ try {
         const options = {
             base: "base...",
             folder: monorepoBasePath.split("/")[1],
-            threshold: 0.1,
+            threshold: 0.05,
         };
 
         // eslint-disable-next-line no-console