Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compressed NFTs #12

Merged
merged 10 commits into from
Jul 24, 2023
Merged

Compressed NFTs #12

merged 10 commits into from
Jul 24, 2023

Conversation

ray-kast
Copy link
Contributor

No description provided.

@kespinola
Copy link
Contributor

kespinola commented Jun 28, 2023 •
edited
Loading

  • Moving all collections to MCC
  • When user goes to mint they can choose for the NFT to be compressed or normal
  • Still need to allow users to mint editons for existing master edition collection
  • Supply becomes a Holaplex tracked entity
  • Mint supports 3 code paths:
    • MCC to normal NFT
    • MCC to compressed NFT
    • Master edition to edition (for existing collections)
  • Transfer supports 2 code paths:
    • Compressed
    • Normal

ray-kast
ray-kast commented Jul 19, 2023
View reviewed changes
Cargo.toml
Comment on lines -5 to -7
[workspace.dependencies]
holaplex-hub-nfts-solana-core = { path = "core" }
holaplex-hub-nfts-solana-entity = { path = "entity" }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note to self: why did i do this?

@kespinola kespinola marked this pull request as ready for review July 24, 2023 20:08
@kespinola kespinola merged commit d8f51c0 into main Jul 24, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ray-kast @kespinola