Support batch mint of random queued nfts #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kespinola
reviewed
Oct 17, 2023
kespinola
requested changes
Oct 17, 2023
consumer/src/events.rs
Outdated
Comment on lines
748
to
749
| .ok_or(ProcessorErrorKind::RecordNotFound) | ||
| .unwrap(); |
There was a problem hiding this comment.
Suggested change
| .ok_or(ProcessorErrorKind::RecordNotFound) | |
| .unwrap(); | |
| .ok_or(ProcessorErrorKind::RecordNotFound)?; |
Comment on lines
+1200
to
+1204
| let blockhash = if let Some(blockhash) = blockhash { | ||
| blockhash | ||
| } else { | ||
| with_retry!(rpc.get_latest_blockhash()).await? | ||
| }; |
There was a problem hiding this comment.
I was thinking unwrap_or_else
https://stackoverflow.com/questions/56726571/why-choosing-unwrap-or-else-over-unwrap-or
There was a problem hiding this comment.
the function is async
| @@ -390,6 +398,7 @@ impl EventKind { | |||
| address: collection_mint.mint, | |||
| }) | |||
| }, | |||
| Self::MintOpenDropBatched => unreachable!(), | |||
There was a problem hiding this comment.
Why not instead of writing a different batch method you incorporate the logic here? Can have helper function for consolidating the logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
todo: update schemas