Backport #279 to main-0.4 #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jost-s
requested changes
Oct 29, 2024
.github/workflows/bundling-test.yml
Outdated
| @@ -4,7 +4,7 @@ on: | |||
| pull_request: | |||
| push: | |||
| branches: | |||
| - "main" | |||
| - "main-0.4" | |||
There was a problem hiding this comment.
This is only for pushes, and generally pushing to main is a rare exception.
There was a problem hiding this comment.
Oh, isn't it for pull requests too? I just wanted the tests to run on this PR (which is to main-0.4) to make sure I didn't mess up with my backporting.
There was a problem hiding this comment.
There's nothing after pull_request:, which means it's not restricted. push: is limited to branches, branches that are called main. So it should run on all PRs anyway.
| @@ -4,8 +4,7 @@ on: | |||
| pull_request: | |||
| push: | |||
| branches: | |||
| - "develop" | |||
| - "main" | |||
| - "main-0.4" | |||
There was a problem hiding this comment.
Same here. We don't need develop here anymore, just main.
|
Okay, requested changes should be addressed. |
jost-s
reviewed
Oct 29, 2024
| ### Changed | ||
| - Update to Holochain 0.4.0-rc.0 | ||
| ### Fixed | ||
| ### Removed | ||
|
|
||
| ## 2024-09-30: v0.18.0-dev.12 | ||
| ## 2024-09-30: v0.18.0-dev.13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.