Skip to content

Commit

Permalink
fix order of steps in release workflow, remove redundant ts-node depe…
Browse files Browse the repository at this point in the history
…ndency
  • Loading branch information
matthme committed Oct 7, 2024
1 parent 7e6a229 commit cac690c
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 13 deletions.
24 changes: 12 additions & 12 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,18 +38,6 @@ jobs:
id: version
shell: bash

- name: Retrieve appId
run: |
echo "APP_ID=$(node ./scripts/read-app-id.js)" >> $GITHUB_OUTPUT
id: appId
shell: bash

- name: Retrieve whether Windows code signing should be attempted
run: |
echo "WINDOWS_CODE_SIGNING=$(node ./scripts/read-windows-code-signing.js)" >> $GITHUB_OUTPUT
id: shouldWindowsCodeSign
shell: bash

- name: install Rust
uses: dtolnay/[email protected]

Expand All @@ -71,6 +59,18 @@ jobs:
curl -f -L --output ./pouch/kando.webhapp https://github.com/holochain-apps/kando/releases/download/v0.10.9/kando.webhapp
node ./scripts/overwrite-with-test-name.js
- name: Retrieve appId
run: |
echo "APP_ID=$(node ./scripts/read-app-id.js)" >> $GITHUB_OUTPUT
id: appId
shell: bash

- name: Retrieve whether Windows code signing should be attempted
run: |
echo "WINDOWS_CODE_SIGNING=$(node ./scripts/read-windows-code-signing.js)" >> $GITHUB_OUTPUT
id: shouldWindowsCodeSign
shell: bash

- name: build and upload the app (macOS arm64)
if: matrix.platform == 'macos-latest'
env:
Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@
"ncp": "^2.0.0",
"octokit": "4.0.2",
"rimraf": "^5.0.1",
"ts-node": "^10.0.0",
"typescript": "~4.5.4",
"vite": "^4.4.9"
}
Expand Down

0 comments on commit cac690c

Please sign in to comment.