Use different icons for save/commit

[ahuang11]

Jim mentioned that the checkmark wasn't intuitive; not sure if this is more intuitive.

or

or

[codspeed-hq]

CodSpeed Performance Report

Merging #102 will not alter performance

_{Comparing use_icons (33213d5) with main (3b08c28)}

Summary

✅ 6 untouched benchmarks

[hoxbro]

I'm definitely not attached to the existing icons, but I don't think these are better.

[ahuang11]

At the very least I think the database is better than a triangle. Maybe it can be a commit icon

[ahuang11]

a

b

c

[hoxbro]

I don't think the database icon is that well-known. Maybe the save icon for upload?

[ahuang11]

[ahuang11]

Actually, maybe using button icons is better, and eventually, with the popups, we can remove the radiobuttongroup.

[hoxbro]

We should not use ButtonIcons before we can replace all buttons with them.

Edit: Maybe it is okay if we align them with the buttons.

[ahuang11]

Okay, let's hold off on this PR for now. Thanks for the intermediate feedback; I think I have a better idea forward once the popups PR is merged:

1. Split out delete from the RadioButtonGroup as a separate ButtonIcon that is only visible when tapped on an existing glyph
2. Use ToggleIcon for + and edit
3. Use ButtonIcon for the rest

[hoxbro]

Unfortunately, you can't use tap only for selection/deletion.

If we have a point-point (1d for both axes), that would also need a tap to mark.

We likely need a mode changer somewhere.

[ahuang11]

I'm not sure I follow.

To clarify, I imagine tapping once on an existing glyph, then a popup shows, containing a ButtonIcon(name="delete"). Upon clicking that ButtonIcon, the selected glyph gets deleted.

[hoxbro]

If you want to make an annotation which is a single point, you would also need to use a tap stream.

[ahuang11]

Still not sure I follow, but I can't seem to create a MRE of a point (and I don't think the docs show how to, unless I missed it)

#103