Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show all elements if nothing is selected by visibile #133

Merged
merged 6 commits into from
Sep 13, 2024
Merged

Don't show all elements if nothing is selected by visibile #133

merged 6 commits into from
Sep 13, 2024

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Sep 12, 2024 •
edited
Loading

Fixes #132

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 12, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #133 will not alter performance

Comparing change_visibility (e53baa3) with main (eb9dbf4)

Summary

✅ 6 untouched benchmarks

@codecov Codecov
Copy link

codecov bot commented Sep 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.79%. Comparing base (eb9dbf4) to head (e53baa3).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #133      +/-   ##
==========================================
+ Coverage   86.74%   86.79%   +0.04%     
==========================================
  Files          26       26              
  Lines        2920     2930      +10     
==========================================
+ Hits         2533     2543      +10     
  Misses        387      387

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro hoxbro marked this pull request as draft September 12, 2024 17:14
@hoxbro hoxbro marked this pull request as ready for review September 13, 2024 07:57
@hoxbro hoxbro requested a review from droumis September 13, 2024 08:01
@droumis
Copy link
Member

droumis commented Sep 13, 2024

LGTM

image

@hoxbro hoxbro merged commit 0a53856 into main Sep 13, 2024
13 checks passed
@hoxbro hoxbro deleted the change_visibility branch September 13, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droumis droumis droumis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot disable visibility of all groups
2 participants
@hoxbro @droumis