Enable changing dtypes for decimate #5790
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mask initialization fails to catch changing dtype (e.g., np.nans from datetime objects). "None" types will not account for these
For decimate, the plot range updates slower than the element range (e.g., whenever the x, y dtypes change from a dynamic map). The element range reflect the current ranges in the new dtype, whereas the self.p.range reflects the previous dtype
Codecov Report
@@ Coverage Diff @@
## main #5790 +/- ##
=======================================
Coverage 88.14% 88.14%
=======================================
Files 307 307
Lines 62850 62850
=======================================
Hits 55401 55401
Misses 7449 7449
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
updating main
philippjfr
reviewed
Jul 24, 2023
| @@ -899,8 +899,8 @@ def _process_layer(self, element, key=None): | |||
| if element.interface not in column_interfaces: | |||
| element = element.clone(tuple(element.columns().values())) | |||
|
|
|||
| xstart, xend = self.p.x_range if self.p.x_range else element.range(0) | |||
| ystart, yend = self.p.y_range if self.p.y_range else element.range(1) | |||
| xstart, xend = element.range(0) | |||
There was a problem hiding this comment.
This doesn't seem correct, it is important that you can pass in the requested x_range and y_range
philippjfr
requested changes
Jul 24, 2023
There was a problem hiding this comment.
Thank you @chrisbotica! The changes for the nan handling seem good but passing in the x_range and y_range to select on is essential to the operation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issues uncovered in #5789 : Select_mask & decimate fail when dtype changes from numeric to date time. Note that without the workaround in #5789, the two bugs are first hidden by the issue in #5405..
This PR:
np.nan