Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Bokeh logging to INFO #4916

Closed
wants to merge 2 commits into from
Closed

Set Bokeh logging to INFO #4916

wants to merge 2 commits into from

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented May 22, 2023

Fixes #2302

Beforehand, this will not output logs because distributed sets the logger level to error. Not sure if we need to have a setting for this.

import distributed  # noqa
import panel as pn
pn.panel("A").servable()

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.25%. Comparing base (70a27c9) to head (37765cb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4916      +/-   ##
==========================================
- Coverage   81.73%   81.25%   -0.49%     
==========================================
  Files         326      326              
  Lines       48006    48003       -3     
==========================================
- Hits        39236    39003     -233     
- Misses       8770     9000     +230     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maximlt
Copy link
Member

maximlt commented May 22, 2023

I want to carefully review this as I have code that relies on logging and have found that setting this up is difficult in general.

@hoxbro hoxbro marked this pull request as draft May 23, 2023 09:02
@philippjfr
Copy link
Member

@maximlt How's the careful review going? 😄

@maximlt
Copy link
Member

maximlt commented Jun 26, 2024

It looks like I have carefully managed not to get to review it :( I promise this will be done this week!

Copy link
Member

@maximlt maximlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I rebased this PR to be able to test it).

I'm -1 on the change as is. It's setting the log level of Bokeh's logger to INFO, ignoring what the user may have configured via BOKEH_PY_LOG_LEVEL or --log-level or whatever logger customisation they might have done in a --setup file.

I opened an issue to report the problem upstream dask/distributed#8750.

@maximlt
Copy link
Member

maximlt commented Jul 4, 2024

There's in fact already a PR to stop setting the logs on import dask/distributed#8634.

@philippjfr philippjfr closed this Aug 1, 2024
@hoxbro hoxbro deleted the always_log branch August 2, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panel serve logs stops working when importing datashader
3 participants