-
-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move chat components into its own namespace #5633
Conversation
Oh I need to actually update the imports. |
Now that it's in its own namespace, would it make sense to drop the "Chat" prefix from ChatInterface, ChatFeed, ChatEntry, etc so that it's |
I believe that is too generic. |
Decided to separate each component into its own module since they're all pretty big. |
Codecov Report
@@ Coverage Diff @@
## main #5633 +/- ##
==========================================
- Coverage 83.65% 81.91% -1.74%
==========================================
Files 280 288 +8
Lines 41580 41678 +98
==========================================
- Hits 34782 34141 -641
- Misses 6798 7537 +739
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 22 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Closes #5625
It's probably a good idea to move these chat components into its own namespace before release to avoid future deprecations and confusion.
I believe that's everything, but I may be forgetting something so let me know if you think of something that needs to be moved too.