Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move chat components into its own namespace #5633

Merged
merged 15 commits into from
Oct 16, 2023
Merged

Move chat components into its own namespace #5633

merged 15 commits into from
Oct 16, 2023

Conversation

ahuang11
Copy link
Contributor

@ahuang11 ahuang11 commented Oct 13, 2023

Closes #5625

It's probably a good idea to move these chat components into its own namespace before release to avoid future deprecations and confusion.

I believe that's everything, but I may be forgetting something so let me know if you think of something that needs to be moved too.

@ahuang11 ahuang11 changed the title Move chat Move chat components into its own namespace Oct 13, 2023
@ahuang11
Copy link
Contributor Author

Oh I need to actually update the imports.

@ahuang11
Copy link
Contributor Author

ahuang11 commented Oct 13, 2023

Now that it's in its own namespace, would it make sense to drop the "Chat" prefix from ChatInterface, ChatFeed, ChatEntry, etc so that it's pn.chat.Interface, pn.chat.Feed, and pn.chat.Entry or is that too generic?

@MarcSkovMadsen
Copy link
Collaborator

Now that it's in its own namespace, would it make sense to drop the "Chat" prefix from ChatInterface, ChatFeed, ChatEntry, etc so that it's pn.chat.Interface, pn.chat.Feed, and pn.chat.Entry or is that too generic?

I believe that is too generic.

panel/widgets/chatbox.py Outdated Show resolved Hide resolved
@ahuang11
Copy link
Contributor Author

Decided to separate each component into its own module since they're all pretty big.

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #5633 (74f34f9) into main (db1e9fe) will decrease coverage by 1.74%.
The diff coverage is 91.23%.

@@            Coverage Diff             @@
##             main    #5633      +/-   ##
==========================================
- Coverage   83.65%   81.91%   -1.74%     
==========================================
  Files         280      288       +8     
  Lines       41580    41678      +98     
==========================================
- Hits        34782    34141     -641     
- Misses       6798     7537     +739     
Flag Coverage Δ
ui-tests 36.05% <28.09%> (-3.54%) ⬇️
unitexamples-tests 73.71% <91.23%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
panel/__init__.py 100.00% <100.00%> (ø)
panel/chat/__init__.py 100.00% <100.00%> (ø)
panel/tests/chat/test_entry.py 100.00% <100.00%> (ø)
panel/tests/chat/test_feed.py 100.00% <100.00%> (ø)
panel/tests/chat/test_icon.py 100.00% <100.00%> (ø)
panel/tests/chat/test_interface.py 100.00% <100.00%> (ø)
panel/widgets/__init__.py 100.00% <ø> (ø)
panel/chat/icon.py 92.64% <92.64%> (ø)
panel/chat/interface.py 95.45% <95.45%> (ø)
panel/chat/feed.py 95.06% <95.06%> (ø)
... and 3 more

... and 22 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 894f1be into main Oct 16, 2023
24 of 28 checks passed
@philippjfr philippjfr deleted the move_chat branch October 16, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Chat Components to their own namespace
3 participants