-
-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add PAM authenticator #6861
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good, two main comments:
- We shouldn't add
pamela
as a core dependency, so the import should be inlined. - We'll need some documentation on how to use it.
I moved the the Pamela import to be a optional dependency and changed the inclusion in the pyproject.toml file. I haven't contributed to the documentation before, is there a best practices guideline for that? |
Regarding best practice for documentation. We are guided by the Diataxis framework for technical documentation https://diataxis.fr/. You might see something non-consistent in practice - either for historical reasons or because we don't yet understand well enough to write according to Diataxis. What I would recommend doing is looking at the documentation for other OAuth Providers and then making a similar contribution. You are very welcome to make a quick draft and ask for some guidance. |
Hi @pgierz . Cool feature! OAuth docs are here: https://panel.holoviz.org/how_to/authentication/providers.html A quick draft that describes the core functionality would be a great start! |
Thanks again @pgierz, I finally got around to this and added some docs. Will merge. |
Hi Panel Team,
I built a very simple PAM authenticator, and it seems to work provided you have given the correct environmental variables. Here is an example, assuming you have an app named
app.py
. For demonstration, I just use the md5 sum of the program code:Or in one line:
Maybe someone else finds this useful.