Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use f-string to show filename in error message correctly #7589

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

kdheepak
Copy link
Contributor

@kdheepak kdheepak commented Jan 5, 2025

This fix makes the string an f-string. Without this change, the error message doesn't show which file is actually missing:

image

@kdheepak
Copy link
Contributor Author

kdheepak commented Jan 5, 2025

I also think this should be a FileNotFoundError exception instead. Let me know if you'd like me to submit a separate PR for that.

@philippjfr
Copy link
Member

I also think this should be a FileNotFoundError exception instead. Let me know if you'd like me to submit a separate PR for that.

Yes, I think so. Also investigating what's up with the test suite, must have regressed somehow over the holidays.

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.10%. Comparing base (400cc44) to head (66a3a46).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
panel/command/convert.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7589      +/-   ##
==========================================
- Coverage   82.11%   82.10%   -0.01%     
==========================================
  Files         340      340              
  Lines       51477    51477              
==========================================
- Hits        42271    42266       -5     
- Misses       9206     9211       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr
Copy link
Member

Thank you!

@philippjfr philippjfr merged commit 0a102aa into holoviz:main Jan 7, 2025
18 checks passed
@kdheepak kdheepak deleted the patch-1 branch January 8, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants