Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip streamz tests on windows due to tornado #7604

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

philippjfr
Copy link
Member

Still having some issues with pytest-asyncio trying to shut down the event loop used by Streamz via Tornado. Tornado issues a ResourceWarning because the IOLoop adds a callback which never runs.

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.11%. Comparing base (400cc44) to head (74ccbf6).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7604   +/-   ##
=======================================
  Coverage   82.11%   82.11%           
=======================================
  Files         340      340           
  Lines       51477    51483    +6     
=======================================
+ Hits        42271    42276    +5     
- Misses       9206     9207    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 410ce99 into main Jan 7, 2025
18 checks passed
@philippjfr philippjfr deleted the skip_streamz_tests_windows branch January 7, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant