Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Stabilize flaky UI test #7620

Merged
merged 29 commits into from
Jan 17, 2025
Merged

test: Stabilize flaky UI test #7620

merged 29 commits into from
Jan 17, 2025

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Jan 16, 2025

No description provided.

@codecov Codecov
Copy link

codecov bot commented Jan 16, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.82759% with 3 lines in your changes missing coverage. Please review.

Project coverage is 86.72%. Comparing base (1786e22) to head (fe126dc).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
panel/tests/ui/pane/test_image.py 66.66% 2 Missing ⚠️
panel/tests/ui/io/test_convert.py 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7620      +/-   ##
==========================================
+ Coverage   86.19%   86.72%   +0.52%     
==========================================
  Files         341      341              
  Lines       51667    51799     +132     
==========================================
+ Hits        44535    44922     +387     
+ Misses       7132     6877     -255

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hoxbro
hoxbro commented Jan 17, 2025
View reviewed changes
panel/tests/ui/test_custom.py Outdated Show resolved Hide resolved
@philippjfr philippjfr marked this pull request as ready for review January 17, 2025 12:34
@hoxbro
Copy link
Member Author

hoxbro commented Jan 17, 2025

The screenshot of the image not loading is:

test-failed-1

@philippjfr philippjfr merged commit 3b06d16 into main Jan 17, 2025
1 check was pending
@philippjfr philippjfr deleted the test_ui branch January 17, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippjfr philippjfr philippjfr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hoxbro @philippjfr