Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some cleanups #1405

Merged
merged 4 commits into from
Aug 1, 2023
Merged

Some cleanups #1405

merged 4 commits into from
Aug 1, 2023

Conversation

zickgraf
Copy link
Member

@zickgraf zickgraf commented Aug 1, 2023

  1. Remove DeductiveSystemForCAP, see DeductiveSystemForCAP #1397
  2. Remove obsolete attribute
  3. Compute property_of from the existing information

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.74% 🎉

Comparison is base (754c8ff) 79.77% compared to head (f3ab77d) 80.52%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1405      +/-   ##
==========================================
+ Coverage   79.77%   80.52%   +0.74%     
==========================================
  Files         500      493       -7     
  Lines       63375    62517     -858     
==========================================
- Hits        50558    50340     -218     
+ Misses      12817    12177     -640     
Flag Coverage Δ
ActionsForCAP 64.76% <ø> (ø)
AttributeCategoryForCAP 88.91% <ø> (ø)
CAP 83.47% <100.00%> (+<0.01%) ⬆️
CartesianCategories 93.50% <ø> (ø)
CompilerForCAP 94.35% <ø> (ø)
ComplexesAndFilteredObjectsForCAP 73.68% <ø> (ø)
DeductiveSystemForCAP ?
FreydCategoriesForCAP 81.25% <ø> (ø)
GeneralizedMorphismsForCAP 61.40% <ø> (ø)
GradedModulePresentationsForCAP 44.60% <ø> (ø)
GroupRepresentationsForCAP 72.06% <ø> (ø)
HomologicalAlgebraForCAP 73.21% <ø> (ø)
InternalExteriorAlgebraForCAP 93.08% <ø> (ø)
LinearAlgebraForCAP 66.57% <ø> (ø)
ModulePresentationsForCAP 68.47% <ø> (ø)
ModulesOverLocalRingsForCAP 90.70% <ø> (ø)
MonoidalCategories 89.00% <ø> (ø)
ToricSheaves 21.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
CAP/gap/LogicForCAP.gd 100.00% <ø> (ø)
CAP/PackageInfo.g 100.00% <100.00%> (ø)
CAP/gap/MethodRecord.gi 91.93% <100.00%> (+0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zickgraf zickgraf merged commit b37bc54 into homalg-project:master Aug 1, 2023
4 checks passed
@zickgraf zickgraf mentioned this pull request Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant