-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce "Target" as an alias of "Range" #1409
Conversation
Do not declare it as a synonym to avoid conflicts with other GAP packages. "Target" seems to be used more widely and has typographical advantages: 1. "Target" naturally comes after "Source" when sorting alphabetically. 2. "Source" and "Target" have the same number of letters. 3. It better matches the maps "s" and "t" which are sometimes used to define categories.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1409 +/- ##
==========================================
- Coverage 80.62% 80.62% -0.01%
==========================================
Files 492 492
Lines 62417 62433 +16
==========================================
+ Hits 50323 50334 +11
- Misses 12094 12099 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
I find this idea great and would have suggested it anyway :) Thank you very much. |
I would even go so far and make |
Perfect, then I will discuss this once more verbally with @sebastianpos and then merge this PR.
This can certainly be a next step, but for now I want to keep things 100% compatible (and first see if this causes problems with other GAP packages). If we want to make |
Agree on all points. |
For the record: |
Do not declare it as a synonym to avoid conflicts with other GAP packages.
"Target" seems to be used more widely and has typographical advantages:
@mohamed-barakat I have already talked to @sebastianpos and @kamalsaleh about this and both are in favor of this change. Do you also approve of this idea?