Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

started supporting list_of_integers_and_list_of_morphisms #1412

Conversation

mohamed-barakat
Copy link
Member

No description provided.

@mohamed-barakat mohamed-barakat force-pushed the list_of_integers_and_list_of_morphisms branch from 231186e to 681bd8f Compare August 7, 2023 17:39
@mohamed-barakat
Copy link
Member Author

I understand why I cannot trigger the new code in OppositeCategory.gi included in this PR with an update in CategoricalTowers. But I do not understand why I cannot trigger the code in CategoryConstructor.gi.

@mohamed-barakat
Copy link
Member Author

I would rather remove unused code and added it back when needed.

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch coverage: 30.00% and project coverage change: -0.01% ⚠️

Comparison is base (0736850) 80.62% compared to head (681bd8f) 80.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1412      +/-   ##
==========================================
- Coverage   80.62%   80.61%   -0.01%     
==========================================
  Files         492      492              
  Lines       62433    62441       +8     
==========================================
+ Hits        50334    50335       +1     
- Misses      12099    12106       +7     
Flag Coverage Δ
ActionsForCAP 64.76% <ø> (ø)
AttributeCategoryForCAP 88.91% <ø> (ø)
CAP 83.82% <30.00%> (-0.04%) ⬇️
CartesianCategories 93.50% <ø> (ø)
CompilerForCAP 94.25% <ø> (ø)
ComplexesAndFilteredObjectsForCAP 73.68% <ø> (ø)
FreydCategoriesForCAP 81.25% <ø> (ø)
GeneralizedMorphismsForCAP 61.40% <ø> (ø)
GradedModulePresentationsForCAP 44.59% <ø> (ø)
GroupRepresentationsForCAP 72.06% <ø> (ø)
HomologicalAlgebraForCAP 73.21% <ø> (ø)
InternalExteriorAlgebraForCAP 93.08% <ø> (ø)
LinearAlgebraForCAP 66.57% <ø> (ø)
ModulePresentationsForCAP 68.41% <ø> (ø)
ModulesOverLocalRingsForCAP 90.70% <ø> (ø)
MonoidalCategories 89.00% <ø> (ø)
ToricSheaves 21.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
CAP/gap/OppositeCategory.gi 95.27% <0.00%> (-0.70%) ⬇️
CAP/gap/ToolsForCategories.gi 85.22% <25.00%> (-0.34%) ⬇️
CAP/gap/CategoryConstructor.gi 94.39% <33.33%> (-0.90%) ⬇️
CAP/PackageInfo.g 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mohamed-barakat
Copy link
Member Author

As discussed yesterday: I now have tests in CategoricalTowers that cover the code changes in

  • CategoryConstructor in this PR,
  • dual_preprocessor_func in method records of MorphismBetweenCoproducts/MorphismBetweenDirectProducts,
  • but not those in Opposite in this PR.

@zickgraf zickgraf merged commit 9944637 into homalg-project:master Aug 10, 2023
2 of 4 checks passed
@mohamed-barakat mohamed-barakat deleted the list_of_integers_and_list_of_morphisms branch August 10, 2023 14:14
@mohamed-barakat
Copy link
Member Author

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants