Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed InstallOtherMethod( CAP_operation, ... ) used by CapAndHomalg.jl #1709

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

mohamed-barakat
Copy link
Member

No description provided.

@mohamed-barakat
Copy link
Member Author

This PR to CAP only affects CapAndHomalg.jl and is needed for the notebooks to work properly. I will merge once the CI succeeds.

Copy link

codecov bot commented Nov 16, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.20%. Comparing base (3721677) to head (15c9f2a).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
CAP/gap/InstallAdds.gi 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1709   +/-   ##
=======================================
  Coverage   81.20%   81.20%           
=======================================
  Files         559      559           
  Lines       79552    79550    -2     
=======================================
  Hits        64597    64597           
+ Misses      14955    14953    -2     
Flag Coverage Δ
ActionsForCAP 64.04% <ø> (ø)
AttributeCategoryForCAP 90.45% <ø> (ø)
CAP 86.29% <33.33%> (+<0.01%) ⬆️
CartesianCategories 89.43% <ø> (ø)
CompilerForCAP 95.90% <ø> (ø)
ComplexesAndFilteredObjectsForCAP 73.55% <ø> (ø)
FreydCategoriesForCAP 82.20% <ø> (ø)
GeneralizedMorphismsForCAP 61.76% <ø> (ø)
GradedModulePresentationsForCAP 44.62% <ø> (ø)
GroupRepresentationsForCAP 71.92% <ø> (ø)
HomologicalAlgebraForCAP 73.21% <ø> (ø)
InternalExteriorAlgebraForCAP 93.09% <ø> (ø)
LinearAlgebraForCAP 52.92% <ø> (ø)
ModulePresentationsForCAP 69.88% <ø> (ø)
ModulesOverLocalRingsForCAP 90.70% <ø> (ø)
MonoidalCategories 89.84% <ø> (ø)
ToricSheaves 21.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mohamed-barakat mohamed-barakat merged commit 7ea646a into homalg-project:master Nov 16, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant