Avoid set several times HACachedStates

[bgoncal]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.87%. Comparing base (48e36a0) to head (950b1e9).

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #56   +/-   ##
=======================================
  Coverage   99.87%   99.87%           
=======================================
  Files          50       50           
  Lines        1593     1595    +2     
=======================================
+ Hits         1591     1593    +2     
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[zacwest]

This is now pretty bad at performance - at least two O(N) added on top of another O(N) enumeration. It's also going to require another step to segment by dictionary again at the end, which is a lot of overhead for all of these changes.

I think it may be better to make the 'all' access lazy, or give HACachedStates an initializer that takes a dictionary, or something along those lines.

[bgoncal]

Shame on me, I made it worse than before :P

I just updated it, I went for dealing with a dictionary for the whole process to avoid wasting by look inside an array and endup creating the cache in the end with an initializer that receives a dictionary as you said