samba: Update smb.gtpl to enable files app on iOS / iPads 18+

[liambresnahan]

This PR is to enable RW access to config directories via files.app which requires new global attributes per https://www.samba.org/samba/docs/4.9/man-html/vfs_streams_xattr.8.html

Summary by CodeRabbit

• Configuration Update
  • Enhanced Samba configuration by adding support for multiple VFS modules to improve extended file attributes management.
  • Updated version number to 12.3.3.
  • Added a new feature for enabling Apple-related Samba configuration changes.

[home-assistant]

Hi @liambresnahan

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Stale

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes involve updating the Samba configuration template file by adding a new Virtual File System (VFS) configuration option. The line vfs objects = catia fruit streams_xattr is introduced in the global section of the Samba configuration. This addition specifies the use of multiple VFS modules, enhancing the management of extended attributes and other file system features for files shared through Samba. Additionally, the version number in the configuration file is updated to 12.3.3, and a new entry is added to the changelog reflecting these changes.

Changes

File	Change Summary
samba/rootfs/usr/share/tempio/smb.gtpl	Added vfs objects = catia fruit streams_xattr under the [global] section to enable support for multiple VFS modules.
samba/CHANGELOG.md	Added entry for version 12.3.3 with note on enabling Apple-related Samba config changes.
samba/config.yaml	Updated version from 12.3.2 to 12.3.3.

Sequence Diagram

sequenceDiagram
    participant Client
    participant Samba Server
    participant VFS Module
    
    Client->>Samba Server: Request file access
    Samba Server->>VFS Module: Apply catia, fruit, streams_xattr modules
    VFS Module-->>Samba Server: Enable extended attribute handling
    Samba Server->>Client: Process file request with extended attribute support

Loading

The sequence diagram illustrates how the new VFS modules are integrated into the Samba file sharing process, intercepting file access requests and enabling extended attribute management.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 45c566d and 13663cb.

📒 Files selected for processing (1)

• samba/CHANGELOG.md (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• samba/CHANGELOG.md

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[agners]

Thanks, the change generally LGTM.

Any change to an add-on which should get rolled out also requires a bump of the add-on version in config.yaml and an entry in CHANGELOG.md.

[agners]

Other than the nit, LGTM, thanks!

[agners]

LGTM, thanks!