Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New thermostat tile for the Wear OS app #4957

Closed
wants to merge 9 commits into from

Conversation

Martreides
Copy link

Summary

This pull request is intended to add a thermostat tile to the Wear OS app. It shows the target and current temperature, and allows a user to change the target temperature. The high level set up of the implementation is based on the existing tiles, mostly the camera tile.

Screenshots

Screenshot_20250105_174129_One UI Watch Home
Screenshot is from a Galaxy Watch 6 Classic, it only has dark mode for tiles.

Link to pull request in Documentation repository

home-assistant/companion.home-assistant#1155

Any other notes

This is my first contribution to an Android project. A good review of the PR is appreciated.

home-assistant[bot]

This comment was marked as resolved.

@home-assistant home-assistant bot marked this pull request as draft January 5, 2025 16:52
@home-assistant
Copy link

home-assistant bot commented Jan 5, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @michielap

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@Martreides
Copy link
Author

@homeassistant, could this PR be deleted since it includes my email address? I will resolve the issue and create a new PR.

@dshokouhi
Copy link
Member

I will see if we can get this deleted. In the future PR please make sure to create a different branch rather than using master directly from your fork. It will cause issues in future PRs.

@Martreides
Copy link
Author

Thanks a lot and apologies. Do you mean that ideally I would create the PR from a different branch of my repo into the master branch of home-assistant/android? Or, from a different branch in my repo to a different branch in home-assistant/android?

@dshokouhi
Copy link
Member

Do you mean that ideally I would create the PR from a different branch of my repo into the master branch of home-assistant/android?

correct different branch from your repo to master here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants