Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Firmata integration image #1633

Closed
wants to merge 2 commits into from

Conversation

DaAwesomeP
Copy link

@DaAwesomeP DaAwesomeP commented May 19, 2020

Proposed change

Adds icon for new Firmata integration. This is the only official image I could find; I could not find anything bigger.

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Removing an icon or logo

Additional information

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for ([email protected])
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side ([email protected])

@frenck frenck added in-progress This PR/Issue is currently being worked on has-parent This PR has a parent PR in a other repo labels May 19, 2020
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure the build passes. Thanks! 👍

@DaAwesomeP
Copy link
Author

@frenck that is the biggest image that I could find. Is the preferred solution to add bordering white space?

@DaAwesomeP
Copy link
Author

I have added white space around the icon—please let me know if that works.

@frenck
Copy link
Member

frenck commented May 19, 2020

Not, we don't generally do that. If there are no images available, we can't add the icons or logos. Alternatively, one could contact the vendor.

@DaAwesomeP
Copy link
Author

OK, I will contact them and ask if they have a newer icon or larger version. I guess I should close this in the meantime. Thanks!

@DaAwesomeP DaAwesomeP closed this May 19, 2020
@DaAwesomeP
Copy link
Author

Just for documentation: I have an issue to update the logo to a new vector I created firmata/protocol#118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-parent This PR has a parent PR in a other repo in-progress This PR/Issue is currently being worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants