Delineate platform support of various deeplink types #1159
Conversation
|
@dshokouhi what do you think about breaking it down like this at the top of the URL Handler integration page? |
docs/integrations/url-handler.md
Outdated
| :::info | ||
| If multiple servers are connected to an app, `fire_event` links will be handled using the first server in the list. | ||
| ::: | ||
|
|
||
| ## Send one shot location |
There was a problem hiding this comment.
I'm curious what the use case for this is. Is it for if you don't share your location by default but want to once to trigger automations etc? Or to force a precise GPS location update? Maybe both are valid usages?
|
Ah looks like https://companion.home-assistant.io/docs/integrations/universal-links does this same thing, but without the header. |
|
@dshokouhi @jpelgrom I think this is ready for merge, if it looks good to you |
…istant into patch-2 # Conflicts: # docs/integrations/url-handler.md
|
@dshokouhi @jpelgrom merge conflicts resolved |
docs/integrations/url-handler.md
Outdated
| <thead> | ||
| <tr> | ||
| <th><strong>Deep Link Type</strong></th> | ||
| <th><img alt="Android" src="/assets/android.svg" /> Full & Minimal</th> |
There was a problem hiding this comment.
Specifying "Full & Minimal" doesn't add any value here, it can only confuse people. Why not simply: Android?
docs/integrations/url-handler.md
Outdated
| <td>✅</td> | ||
| </tr> | ||
| <tr> | ||
| <td>Call Service</td> |
There was a problem hiding this comment.
Use sentence case
| <td>Call Service</td> | |
| <td>Call service</td> |
docs/integrations/url-handler.md
Outdated
| <td>✅</td> | ||
| </tr> | ||
| <tr> | ||
| <td>Fire Event</td> |
There was a problem hiding this comment.
Use sentence case
| <td>Fire Event</td> | |
| <td>Fire event</td> |
docs/integrations/url-handler.md
Outdated
| <td>✅</td> | ||
| </tr> | ||
| <tr> | ||
| <td>Send Location</td> |
There was a problem hiding this comment.
Use sentence case and match heading
| <td>Send Location</td> | |
| <td>Send one shot location</td> |
There was a problem hiding this comment.
do you have a preference of "Send one shot location" over "Send location"? I prefer the latter, I think because "one shot" is a bit redundant and maybe a little metaphorical, but happy to adopt whichever you prefer.
docs/integrations/url-handler.md
Outdated
| @@ -5,11 +5,41 @@ id: 'url-handler' | |||
|
|
|||
| Home Assistant supports opening from other apps via URL. | |||
|
|
|||
| Query parameters are passed as a dictionary in the call. | |||
| ## Platform Compatibility | |||
There was a problem hiding this comment.
Use sentence case - the current page may not always match the standards but let's try to keep them in mind for new documentation.
docs/integrations/url-handler.md
Outdated
| <table className="core-table"> | ||
| <thead> | ||
| <tr> | ||
| <th><strong>Deep Link Type</strong></th> |
There was a problem hiding this comment.
Consistency with your previous paragraph and use sentence case
| <th><strong>Deep Link Type</strong></th> | |
| <th><strong>Deeplink type</strong></th> |
|
Please don't @ mention contributors just because you don't get a quick answer. |
|
Ah the mention was not because of impatience I just saw the other PR had gone in mentioning conflicts with this one, so I tagged you just to communicate that I resolved them. No offense was meant, but I'll not use mentions going forward. |
No description provided.