-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove unneeded type attributes on WebsocketNotification #123238
Conversation
This change removes the type attributes on WebsocketNotification which will become errors as of python/mypy#17207 see: https://typing.readthedocs.io/en/latest/spec/enums.html#defining-members:~:text=Members%20defined%20within%20an%20enum%20class%20should%20not%20include%20explicit%20type%20annotations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hey there @mj23000, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Thanks, @terencehonles 👍 |
Proposed change
This change removes the type attributes on WebsocketNotification which will become errors as of python/mypy#17207
see: https://typing.readthedocs.io/en/latest/spec/enums.html#defining-members:~:text=Members%20defined%20within%20an%20enum%20class%20should%20not%20include%20explicit%20type%20annotations.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: